Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: ui/views/view.cc

Issue 2745163003: Improve doc of ViewObserver and clarify arguments (Closed)
Patch Set: moar Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/view.cc
diff --git a/ui/views/view.cc b/ui/views/view.cc
index 359ef565fd88ae041f2769b70f6fc87f3360237d..b954ec3d90920805bcc465592e98964065c707c7 100644
--- a/ui/views/view.cc
+++ b/ui/views/view.cc
@@ -252,7 +252,7 @@ void View::AddChildViewAt(View* view, int index) {
layout_manager_->ViewAdded(this, view);
for (ViewObserver& observer : observers_)
- observer.OnChildViewAdded(view);
+ observer.OnChildViewAdded(this, view);
}
void View::ReorderChildView(View* view, int index) {
@@ -284,7 +284,7 @@ void View::ReorderChildView(View* view, int index) {
children_.insert(children_.begin() + index, view);
for (ViewObserver& observer : observers_)
- observer.OnChildViewReordered(view);
+ observer.OnChildViewReordered(this, view);
ReorderLayers();
}
@@ -1964,7 +1964,7 @@ void View::DoRemoveChildView(View* view,
layout_manager_->ViewRemoved(this, view);
for (ViewObserver& observer : observers_)
- observer.OnChildViewRemoved(view, this);
+ observer.OnChildViewRemoved(this, view);
}
void View::PropagateRemoveNotifications(View* old_parent,

Powered by Google App Engine
This is Rietveld 408576698