Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2745113003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
boliu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (android, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=boliu@chromium.org Review-Url: https://codereview.chromium.org/2745113003 Cr-Commit-Position: refs/heads/master@{#456430} Committed: https://chromium.googlesource.com/chromium/src/+/46237dd82d3a34ae0702a8395992f76ed6a3ad95

Patch Set 1 : \ #

Total comments: 6

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M android_webview/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/web_contents_delegate_android/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M device/power_save_blocker/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/display/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-13 17:29:36 UTC) #2
boliu
https://codereview.chromium.org/2745113003/diff/20001/components/web_contents_delegate_android/OWNERS File components/web_contents_delegate_android/OWNERS (right): https://codereview.chromium.org/2745113003/diff/20001/components/web_contents_delegate_android/OWNERS#newcode4 components/web_contents_delegate_android/OWNERS:4: # COMPONENT: Mobile>WebView should be Internals>Core, following content, and ...
3 years, 9 months ago (2017-03-13 17:47:26 UTC) #3
ymzhang1
Thanks for the comments! https://codereview.chromium.org/2745113003/diff/20001/components/web_contents_delegate_android/OWNERS File components/web_contents_delegate_android/OWNERS (right): https://codereview.chromium.org/2745113003/diff/20001/components/web_contents_delegate_android/OWNERS#newcode4 components/web_contents_delegate_android/OWNERS:4: # COMPONENT: Mobile>WebView On 2017/03/13 ...
3 years, 9 months ago (2017-03-13 17:58:36 UTC) #5
boliu
lgtm
3 years, 9 months ago (2017-03-13 18:01:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745113003/60001
3 years, 9 months ago (2017-03-13 18:03:43 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 18:16:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/46237dd82d3a34ae0702a8395992...

Powered by Google App Engine
This is Rietveld 408576698