Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2745063005: Remove document.rootScroller compositing clipping effects. (Closed)

Created:
3 years, 9 months ago by bokan
Modified:
3 years, 9 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove document.rootScroller compositing clipping effects. This is basically a revert of: https://crrev.com/7ab964b30f73e3507ac3a424f56b1a9101b9bca3 Turns out that mucking with clips at the paint stage of the lifecycle is problematic for document.rootScroller so I'm taking a different approach and removing all the modifications to painting code. BUG=505516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2745063005 Cr-Commit-Position: refs/heads/master@{#456770} Committed: https://chromium.googlesource.com/chromium/src/+/42c4d3b900752d93f6da6fb4f3dac6d367ac5727

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -844 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/basic-disable-ancestor-clipping.html View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/basic-disable-ancestor-clipping-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/basic-disable-ancestor-clipping-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/basic-reenable-ancestor-clipping.html View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/basic-reenable-ancestor-clipping-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/basic-reenable-ancestor-clipping-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/clipping-ancestor-is-composited-sibling.html View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/clipping-ancestor-is-composited-sibling-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/clipping-ancestor-is-composited-sibling-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/clipping-ancestor-is-non-composited-sibling.html View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/clipping-ancestor-is-non-composited-sibling-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/clipping-ancestor-is-non-composited-sibling-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/resources/clipping-ancestor-is-composited-sibling-iframe.html View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/root-scroller/resources/clipping-ancestor-is-non-composited-sibling-iframe.html View 1 chunk +0 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 4 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 2 chunks +0 lines, -149 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 4 chunks +14 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp View 2 chunks +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 1 1 chunk +0 lines, -188 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (18 generated)
bokan
PTAL, I'm undoing all the compositing tweaks added for document.rootScroller in favour of applying approprate ...
3 years, 9 months ago (2017-03-14 17:12:07 UTC) #16
chrishtr
lgtm
3 years, 9 months ago (2017-03-14 18:26:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745063005/40001
3 years, 9 months ago (2017-03-14 18:27:07 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 18:36:27 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/42c4d3b900752d93f6da6fb4f3da...

Powered by Google App Engine
This is Rietveld 408576698