[regexp] Add slow exec stub to reduce code size

[regexp] Add slow exec stub to reduce code size

CSA builtins can become very large, and the RegExp builtins are currently the
main offender (e.g. @@match's code size is over 50k). This is due to the fact
that most RegExp builtins rely on RegExpBuiltinExec (fairly large itself),
which is then inlined multiple times in many builtins.

This CL reduces the snapshot size for an x64 release build by 80k by turning
slow-path RegExpBuiltinExec calls into stub calls (i.e. removing code
duplication through inlining) and completely removing the code path for fast
RegExp instances in RegExpExec (it is never taken).

BUG=v8:5339, v8:5737
Review-Url: https://codereview.chromium.org/2745053003
Cr-Commit-Position: refs/heads/master@{#43889}
Committed: https://chromium.googlesource.com/v8/v8/+/10f7b7ecc686b34d13ac3fa5f789dfce1c963711

[jgruber, 2017-03-13 15:30:04]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 15:30:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-13 15:49:22]

jgruber@chromium.org changed reviewers:
+ ishell@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:00:12]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-03-13 16:30:32]

lgtm

https://codereview.chromium.org/2745053003/diff/1/src/builtins/builtins-regex...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2745053003/diff/1/src/builtins/builtins-regex...
src/builtins/builtins-regexp.cc:1498: BranchIfFastRegExp(context, map,
&if_isfastpath, &if_isslowpath);
I guess it's better to skip this check and jump directly to slow path.

[jgruber, 2017-03-17 09:39:28]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 09:39:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-17 09:51:23]

https://codereview.chromium.org/2745053003/diff/1/src/builtins/builtins-regex...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2745053003/diff/1/src/builtins/builtins-regex...
src/builtins/builtins-regexp.cc:1498: BranchIfFastRegExp(context, map,
&if_isfastpath, &if_isslowpath);
On 2017/03/13 16:30:32, Igor Sheludko wrote:
> I guess it's better to skip this check and jump directly to slow path.

Done.

[jgruber, 2017-03-17 10:03:13]

The CQ bit was unchecked by jgruber@chromium.org

[jgruber, 2017-03-17 10:03:17]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-03-17 10:03:17]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2745053003/#ps20001
(title: "Rebase and non-generic descriptor")

[commit-bot: I haz the power, 2017-03-17 10:03:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 10:48:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489744997363290,
"parent_rev": "162553a12a74bd2040a562220e5b3c2611278cbb", "commit_rev":
"10f7b7ecc686b34d13ac3fa5f789dfce1c963711"}

[commit-bot: I haz the power, 2017-03-17 10:48:52]

Description was changed from

==========
[regexp] Add slow exec stub to reduce code size

CSA builtins can become very large, and the RegExp builtins are currently the
main offender (e.g. @@match's code size is over 50k). This is due to the fact
that most RegExp builtins rely on RegExpBuiltinExec (fairly large itself),
which is then inlined multiple times in many builtins.

This CL reduces the snapshot size for an x64 release build by 80k by turning
slow-path RegExpBuiltinExec calls into stub calls (i.e. removing code
duplication through inlining) and completely removing the code path for fast
RegExp instances in RegExpExec (it is never taken).

BUG=v8:5339,v8:5737
==========

to

==========
[regexp] Add slow exec stub to reduce code size

CSA builtins can become very large, and the RegExp builtins are currently the
main offender (e.g. @@match's code size is over 50k). This is due to the fact
that most RegExp builtins rely on RegExpBuiltinExec (fairly large itself),
which is then inlined multiple times in many builtins.

This CL reduces the snapshot size for an x64 release build by 80k by turning
slow-path RegExpBuiltinExec calls into stub calls (i.e. removing code
duplication through inlining) and completely removing the code path for fast
RegExp instances in RegExpExec (it is never taken).

BUG=v8:5339,v8:5737

Review-Url: https://codereview.chromium.org/2745053003
Cr-Commit-Position: refs/heads/master@{#43889}
Committed:
https://chromium.googlesource.com/v8/v8/+/10f7b7ecc686b34d13ac3fa5f789dfce1c9...
==========

[commit-bot: I haz the power, 2017-03-17 10:48:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/10f7b7ecc686b34d13ac3fa5f789dfce1c9...