Source/bindings/scripts/v8_methods.py - Issue 274503002: Remove v8_interface.constructor_argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 274503002: Remove v8_interface.constructor_argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index dd32e7c7251a2e34b83f721c7d8fec6947755aa8..e748e34c7bbfadf458d5369c37211ca0d93ef026 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -230,7 +230,8 @@ def cpp_value(interface, method, number_of_arguments):

def v8_set_return_value(interface_name, method, cpp_value, for_main_world=False):

idl_type = method.idl_type

extended_attributes = method.extended_attributes

- if idl_type.name == 'void':

+ if not idl_type or idl_type.name == 'void':

+ # Constructors and void methods don't have a return type

return None

release = False

« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | no next file » | no next file with comments »