Issue 274503002: Remove v8_interface.constructor_argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274503002: Remove v8_interface.constructor_argument (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)

Modified:
6 years, 7 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, blink-reviews-bindings_chromium.org, Nate Chapin, Jens Widell

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove v8_interface.constructor_argument Refactoring, no changes to generated bindings. v8_interface.constructor_argument() is redundant with v8_methods.generate_argument() (It's just a simplified version, as pointed out by Jens - thanks!) There's one v. minor change required to merge this: constructors have None as their idl_type, so check for that in addition to 'void'. R=haraken BUG=345503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173467

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -20 lines)			Patch
	M	Source/bindings/scripts/v8_interface.py	View		2 chunks	+1 line, -19 lines	0 comments	Download
	M	Source/bindings/scripts/v8_methods.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 7 months ago (2014-05-07 03:18:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/274503002/1

6 years, 7 months ago (2014-05-07 03:19:19 UTC) #4

Message was sent while issue was closed.

Change committed as 173467

Expand Messages | Collapse Messages