Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2745003003: Moved the FakeDownloadItem to content/public/test. (Closed)

Created:
3 years, 9 months ago by harkness
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved the FakeDownloadItem to content/public/test. The new tab page tests implemented a mostly-complete FakeDownloadItem. content/public/test already contains a mock for a DownloadItem and Fakes for other classes, and the BackgroundFetch tests will also be needing a fake DownloadItem, so this CL moves the FakeDownloadItem to the more accessible location. BUG=692621 Review-Url: https://codereview.chromium.org/2745003003 Cr-Commit-Position: refs/heads/master@{#456394} Committed: https://chromium.googlesource.com/chromium/src/+/41f3b13b61278aa9aa7660b6acfd22091cdc75e5

Patch Set 1 #

Patch Set 2 : Fix merge issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -606 lines) Patch
D chrome/browser/ntp_snippets/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ntp_snippets/fake_download_item.h View 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/browser/ntp_snippets/fake_download_item.cc View 1 chunk +0 lines, -410 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A + content/public/test/fake_download_item.h View 1 6 chunks +11 lines, -12 lines 0 comments Download
A + content/public/test/fake_download_item.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
harkness
3 years, 9 months ago (2017-03-13 11:16:40 UTC) #2
Bernhard Bauer
lgtm
3 years, 9 months ago (2017-03-13 14:39:48 UTC) #3
harkness
avi@ for new content location.
3 years, 9 months ago (2017-03-13 14:45:16 UTC) #5
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-13 15:17:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745003003/20001
3 years, 9 months ago (2017-03-13 15:22:50 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 16:15:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41f3b13b61278aa9aa7660b6acfd...

Powered by Google App Engine
This is Rietveld 408576698