Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2744933003: Re-enable vpython/venv's TestVirtualEnv. (Closed)

Created:
3 years, 9 months ago by dnj
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Re-enable vpython/venv's TestVirtualEnv. Re-enable the previously-flaky test, TestVirtualEnv. The flake is believed to be due to the test re-using the output directory to build testing wheel files. Now, the test builds each wheel in its own temporary, isolating them from each other. TBR=iannucci@chromium.org BUG=chromium:691818 TEST=None Review-Url: https://codereview.chromium.org/2744933003 Committed: https://github.com/luci/luci-go/commit/6a55c1dc81825688ac63b65b2b14a9370de0a0b0

Patch Set 1 #

Patch Set 2 : better comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -9 lines) Patch
M vpython/venv/venv_resources_test.go View 1 2 chunks +44 lines, -6 lines 0 comments Download
M vpython/venv/venv_test.go View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744933003/20001
3 years, 9 months ago (2017-03-11 22:08:52 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 22:14:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/6a55c1dc81825688ac63b65b2b14a9370de0a0b0

Powered by Google App Engine
This is Rietveld 408576698