Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2744923002: cr-policy-indicator element for non-preference-based indicators (Closed)

Created:
3 years, 9 months ago by michaelpg
Modified:
3 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cr-policy-indicator element for non-preference-based indicators BUG=648498 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2744923002 Cr-Commit-Position: refs/heads/master@{#456259} Committed: https://chromium.googlesource.com/chromium/src/+/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891

Patch Set 1 #

Patch Set 2 : alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -40 lines) Patch
M chrome/browser/resources/settings/date_time_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.js View 2 chunks +5 lines, -23 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/cr_elements/cr_elements_browsertest.js View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/test/data/webui/cr_elements/cr_policy_indicator_tests.js View 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/date_time_page_tests.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_item.html View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/webui/resources/cr_elements/policy/README.md View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/policy/compiled_resources2.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
A ui/webui/resources/cr_elements/policy/cr_policy_indicator.html View 1 chunk +28 lines, -0 lines 0 comments Download
A ui/webui/resources/cr_elements/policy/cr_policy_indicator.js View 1 chunk +14 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
michaelpg
PTAL. The duplication of cr-policy-pref-indicator's code is unfortunate, but I think the extra element is ...
3 years, 9 months ago (2017-03-10 23:26:39 UTC) #2
stevenjb
Agreed, nice cleanup, lgtm.
3 years, 9 months ago (2017-03-11 00:08:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744923002/20001
3 years, 9 months ago (2017-03-11 01:16:49 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 02:20:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/67c8ffe8dc73fb95bb8fcfe63fd5...

Powered by Google App Engine
This is Rietveld 408576698