Issue 2744883002: Migrate the pref to always show the Cast icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2744883002: Migrate the pref to always show the Cast icon (Closed)

Created:
3 years, 9 months ago by imcheng

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Migrate the pref to always show the Cast icon This CL fixes the bug in which the user preference to pin the Cast toolbar icon disappears due to the lack of migration from the old pref to the new pref. BUG=698931 Review-Url: https://codereview.chromium.org/2736863002 Cr-Commit-Position: refs/heads/master@{#455525} (cherry picked from commit fb4e8ac40deaad4025dcacd96c9be4fbf2b7d193) Review-Url: https://codereview.chromium.org/2744883002 . Cr-Commit-Position: refs/branch-heads/3029@{#115} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/a0d87961d1bf1d99aa7a82d5166be3aef1ec75f4

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -2 lines)			Patch
	M	chrome/browser/prefs/browser_prefs.cc	View		2 chunks	+21 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc	View		4 chunks	+31 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

imcheng

3 years, 9 months ago (2017-03-10 18:36:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a0d87961d1bf1d99aa7a82d5166be3aef1ec75f4.