Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2744773002: [DevTools] Fix ObjectPopover for objects not staying the same size (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
alph, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix ObjectPopover for objects not staying the same size When you expand things inside, popover can change size which is unexpected. Regressed with crrev.com/72b6d79734c7fd5925b6f862c588229b0207afe6 BUG=none Review-Url: https://codereview.chromium.org/2744773002 Cr-Commit-Position: refs/heads/master@{#455997} Committed: https://chromium.googlesource.com/chromium/src/+/09aef2278437c8832d1dda60c8fa4641418f6e19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/objectPopover.css View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dgozman
Take a look please.
3 years, 9 months ago (2017-03-10 01:47:42 UTC) #2
dgozman
Andrey, mind taking a look?
3 years, 9 months ago (2017-03-10 01:52:16 UTC) #6
lushnikov
lgtm
3 years, 9 months ago (2017-03-10 02:14:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744773002/1
3 years, 9 months ago (2017-03-10 04:34:43 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 04:39:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/09aef2278437c8832d1dda60c8fa...

Powered by Google App Engine
This is Rietveld 408576698