Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2744763003: [MD settings] CSS var --checkbox-spacing to --settings-control-spacing (Closed)

Created:
3 years, 9 months ago by dschuyler
Modified:
3 years, 9 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dcheng, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, stevenjb, Dan Beam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] CSS var --checkbox-spacing to --settings-control-spacing This CL changes the name of a CSS variable. The checkbox spacing was/is being used for spacing between a control label and something graphical such as the checkbox or a policy indicator. The intent is to convey that it's used for more than checkbox spacing. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2744763003 Cr-Commit-Position: refs/heads/master@{#456132} Committed: https://chromium.googlesource.com/chromium/src/+/b6b3ddb97f0813f12cd304f3b125d17393920350

Patch Set 1 #

Messages

Total messages: 13 (9 generated)
dschuyler
3 years, 9 months ago (2017-03-10 01:55:04 UTC) #5
tommycli
great cleanup LGTM
3 years, 9 months ago (2017-03-10 02:01:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744763003/1
3 years, 9 months ago (2017-03-10 19:18:53 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 19:27:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6b3ddb97f0813f12cd304f3b125...

Powered by Google App Engine
This is Rietveld 408576698