Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2744733002: [PerfBotSheriff] Disable a v8 top 25 page (Closed)

Created:
3 years, 9 months ago by fmeawad
Modified:
3 years, 9 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, Camillo Bruni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PerfBotSheriff] Disable a v8 top 25 page Disable sina.com.cn as if fails as part of v8.runtime_stats.top_25 on Linux BUG=699579 Review-Url: https://codereview.chromium.org/2744733002 Cr-Commit-Position: refs/heads/master@{#455955} Committed: https://chromium.googlesource.com/chromium/src/+/9018c99b7f73801b958f5079f68a8fda1519f480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/page_sets/v8_top_25.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
fmeawad
Benchmark running on mac and linux, disabling the page on both is better than disabling ...
3 years, 9 months ago (2017-03-09 23:26:29 UTC) #2
nednguyen
lgtm
3 years, 9 months ago (2017-03-10 00:39:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744733002/1
3 years, 9 months ago (2017-03-10 00:47:22 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 01:43:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9018c99b7f73801b958f5079f68a...

Powered by Google App Engine
This is Rietveld 408576698