Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2744723002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
Peter Beverloo, dewittj
CC:
chromium-reviews, extensions-reviews_chromium.org, awdf+watch_chromium.org, dewittj+watch_chromium.org, Peter Beverloo, fgorski+watch_chromium.org, mlamouri+watch-notifications_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, chromium-apps-reviews_chromium.org, tfarina, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (offline_pages, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=dewittj@chromium.org Review-Url: https://codereview.chromium.org/2744723002 Cr-Commit-Position: refs/heads/master@{#455953} Committed: https://chromium.googlesource.com/chromium/src/+/589c696ecd13c722eb3b7eeef6eb43791978a687

Patch Set 1 #

Patch Set 2 : update component #

Total comments: 10

Patch Set 3 : update team/component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/notifications/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/system_indicator/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/message_center/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/offline_pages/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-09 22:00:26 UTC) #1
Peter Beverloo
(Random drive-by since I'm on the message_center watch list, sorry. Thanks for doing this once ...
3 years, 9 months ago (2017-03-09 22:09:14 UTC) #3
ymzhang1
On 2017/03/09 22:09:14, Peter Beverloo wrote: > (Random drive-by since I'm on the message_center watch ...
3 years, 9 months ago (2017-03-09 22:35:07 UTC) #4
dewittj
https://codereview.chromium.org/2744723002/diff/20001/chrome/browser/extensions/api/system_indicator/OWNERS File chrome/browser/extensions/api/system_indicator/OWNERS (right): https://codereview.chromium.org/2744723002/diff/20001/chrome/browser/extensions/api/system_indicator/OWNERS#newcode3 chrome/browser/extensions/api/system_indicator/OWNERS:3: # COMPONENT: UI>Browser>Omnibox>SecurityIndicators Platform > Apps https://codereview.chromium.org/2744723002/diff/20001/chrome/browser/ui/views/message_center/OWNERS File chrome/browser/ui/views/message_center/OWNERS ...
3 years, 9 months ago (2017-03-09 22:38:14 UTC) #5
ymzhang1
https://codereview.chromium.org/2744723002/diff/20001/chrome/browser/extensions/api/notifications/OWNERS File chrome/browser/extensions/api/notifications/OWNERS (right): https://codereview.chromium.org/2744723002/diff/20001/chrome/browser/extensions/api/notifications/OWNERS#newcode3 chrome/browser/extensions/api/notifications/OWNERS:3: # TEAM: platform-capabilities@chromium.org On 2017/03/09 22:09:14, Peter Beverloo wrote: ...
3 years, 9 months ago (2017-03-10 01:04:59 UTC) #6
dewittj
lgtm
3 years, 9 months ago (2017-03-10 01:08:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744723002/40001
3 years, 9 months ago (2017-03-10 01:11:09 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 01:39:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/589c696ecd13c722eb3b7eeef6eb...

Powered by Google App Engine
This is Rietveld 408576698