Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 2744713003: Move "Turn on Bluetooth to allow pairing" to top-left on chooser on Android (Closed)

Created:
3 years, 9 months ago by juncai
Modified:
3 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move "Turn on Bluetooth to allow pairing" to top-left on chooser on Android This CL is a follow-up for: https://codereview.chromium.org/2627483003 After discussion with UI team, the text message on the chooser should stay on the top-left as it was before the above CL. So this CL changes it back. BUG=664240 Review-Url: https://codereview.chromium.org/2744713003 Cr-Commit-Position: refs/heads/master@{#456111} Committed: https://chromium.googlesource.com/chromium/src/+/51428a67c2be408c20522f9c35be693fe84e6a98

Patch Set 1 : move "Turn on Bluetooth to allow pairing" to top-left on chooser on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M chrome/android/java/res/layout/item_chooser_dialog.xml View 2 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
juncai
Please take a look.
3 years, 9 months ago (2017-03-10 04:13:34 UTC) #6
Ted C
lgtm
3 years, 9 months ago (2017-03-10 04:34:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744713003/1
3 years, 9 months ago (2017-03-10 18:14:32 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 18:19:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51428a67c2be408c20522f9c35be...

Powered by Google App Engine
This is Rietveld 408576698