Use default copy constructor for ComputedStyleBase.

Use default copy constructor for ComputedStyleBase.

The current copy constructor ComputedStyleBase doesn't do anything
special. This patch removes it so we can just let C++ generate the
default copy constructor instead. When we have opportunities for faster
copy in the future (e.g. using memcpy), we will generate the copy
constructor explicitly.

BUG=628043
Review-Url: https://codereview.chromium.org/2744693002
Cr-Commit-Position: refs/heads/master@{#457637}
Committed: https://chromium.googlesource.com/chromium/src/+/9fa493ef60bc0a4d61858f644b1095cf2a0f6a52

[shend, 2017-03-09 19:50:13]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-03-09 19:50:13]

Hi Bugs, PTAL

[shend, 2017-03-09 19:50:21]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 19:51:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 19:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 19:53:31]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-03-09 21:42:07]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 21:42:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-03-09 23:46:59]

lgtm

[shend, 2017-03-09 23:47:34]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-03-09 23:47:34]

Hi Eddy, PTAL

[commit-bot: I haz the power, 2017-03-09 23:54:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 23:54:46]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2017-03-10 04:09:11]

lgtm

https://codereview.chromium.org/2744693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
(left):

https://codereview.chromium.org/2744693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:31:
ALWAYS_INLINE ComputedStyleBase(const ComputedStyleBase& o) :
Are we sure all the members of ComputedStyleBase will always all have their own
copy constructors? If any one of them doesn't, the compiler won't generate
this...

But - that might become a compile error in that case, where it wouldn't here, so
¯\_(ツ)_/¯

[shend, 2017-03-10 05:54:52]

https://codereview.chromium.org/2744693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
(left):

https://codereview.chromium.org/2744693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:31:
ALWAYS_INLINE ComputedStyleBase(const ComputedStyleBase& o) :
On 2017/03/10 at 04:09:11, Eddy wrote:
> Are we sure all the members of ComputedStyleBase will always all have their
own copy constructors? If any one of them doesn't, the compiler won't generate
this...
> 
> But - that might become a compile error in that case, where it wouldn't here,
so ¯\_(ツ)_/¯

Hopefully that won't happen :P Anyway, if one of the members is noncopyable,
this code will fail too since we're just calling the copy ctors of each member
right? To handle noncopyable members, we'd have to teach the generator how to
copy special fields, which is quite yuck.

[shend, 2017-03-15 04:20:08]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-15 04:20:09]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2744693002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-15 04:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 04:20:37]

This CL has an open dependency (Issue 2739553003 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[shend, 2017-03-16 22:10:28]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 22:11:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 22:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 22:13:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[shend, 2017-03-16 22:45:52]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 22:46:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 00:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 00:16:36]

Dry run: This issue passed the CQ dry run.

[shend, 2017-03-17 00:50:14]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-17 00:50:15]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2744693002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-17 00:50:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 00:55:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489711814786970,
"parent_rev": "f99ae39b7445952db64971ae798c8dc83b5776f1", "commit_rev":
"9fa493ef60bc0a4d61858f644b1095cf2a0f6a52"}

[commit-bot: I haz the power, 2017-03-17 00:56:03]

Description was changed from

==========
Use default copy constructor for ComputedStyleBase.

The current copy constructor ComputedStyleBase doesn't do anything
special. This patch removes it so we can just let C++ generate the
default copy constructor instead. When we have opportunities for faster
copy in the future (e.g. using memcpy), we will generate the copy
constructor explicitly.

BUG=628043
==========

to

==========
Use default copy constructor for ComputedStyleBase.

The current copy constructor ComputedStyleBase doesn't do anything
special. This patch removes it so we can just let C++ generate the
default copy constructor instead. When we have opportunities for faster
copy in the future (e.g. using memcpy), we will generate the copy
constructor explicitly.

BUG=628043

Review-Url: https://codereview.chromium.org/2744693002
Cr-Commit-Position: refs/heads/master@{#457637}
Committed:
https://chromium.googlesource.com/chromium/src/+/9fa493ef60bc0a4d61858f644b10...
==========

[commit-bot: I haz the power, 2017-03-17 00:56:05]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9fa493ef60bc0a4d61858f644b10...