Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2744663006:
Fix skip EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve (Closed)
DescriptionFix skip EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve
on NVIDIA Shield.
BUG=700060
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2744663006
Cr-Commit-Position: refs/heads/master@{#456940}
Committed: https://chromium.googlesource.com/chromium/src/+/f47407132408753d4ef23a27545ec2a5fe84791e
Patch Set 1 #Patch Set 2 : GPUInfo -> GPUTestBotConfig #
Total comments: 3
Patch Set 3 : GPUTestBotConfig -> GLManager #Messages
Total messages: 19 (13 generated)
Description was changed from ========== Fix skip EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve on NVIDIA Shield. BUG=700060 ========== to ========== Fix skip EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve on NVIDIA Shield. BUG=700060 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
ynovikov@chromium.org changed reviewers: + geofflang@chromium.org, zmo@chromium.org
I can't find anything wrong with https://codereview.chromium.org/2741853005/, but it doesn't skip. Unfortunately, I can't investigate without NVIDIA Shield. Here is a different approach.
The CQ bit was checked by ynovikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ynovikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2744663006/diff/20001/gpu/config/gpu_test_con... File gpu/config/gpu_test_config.cc (right): https://codereview.chromium.org/2744663006/diff/20001/gpu/config/gpu_test_con... gpu/config/gpu_test_config.cc:157: config.machine_model_name_ != machine_model_name_) Can you add a unit test for this? https://codereview.chromium.org/2744663006/diff/20001/gpu/config/gpu_test_con... gpu/config/gpu_test_config.cc:251: if (!config.machine_model_name().empty() && Can you add a unit test for this? https://codereview.chromium.org/2744663006/diff/20001/gpu/config/gpu_test_con... File gpu/config/gpu_test_config.h (right): https://codereview.chromium.org/2744663006/diff/20001/gpu/config/gpu_test_con... gpu/config/gpu_test_config.h:77: std::string machine_model_name() const { return machine_model_name_; } nit: return const std::string&
PTAL. I'm not using GPUTestBotConfig anymore, so previous comments don't apply. Sorry for flip-flopping with the implementation approach.
On 2017/03/15 00:04:43, ynovikov wrote: > PTAL. > > I'm not using GPUTestBotConfig anymore, so previous comments don't apply. > Sorry for flip-flopping with the implementation approach. lgtm
The CQ bit was checked by ynovikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489536805697570,
"parent_rev": "becaabeceb9fbb249e4c7a72b85f4f20cd826f95", "commit_rev":
"f47407132408753d4ef23a27545ec2a5fe84791e"}
Message was sent while issue was closed.
Description was changed from ========== Fix skip EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve on NVIDIA Shield. BUG=700060 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix skip EXTMultisampleCompatibilityTest.DrawAlphaOneAndResolve on NVIDIA Shield. BUG=700060 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2744663006 Cr-Commit-Position: refs/heads/master@{#456940} Committed: https://chromium.googlesource.com/chromium/src/+/f47407132408753d4ef23a27545e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f47407132408753d4ef23a27545e... |
