Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2744623002: Fix x86 VrShellDelegate crash (Closed)

Created:
3 years, 9 months ago by mthiesse
Modified:
3 years, 9 months ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix x86 VrShellDelegate crash Changes VrShellDelegate to only be created when VR classes are available, and adds a check to static native method to ensure VR classes are available. BUG=700002 Review-Url: https://codereview.chromium.org/2744623002 Cr-Commit-Position: refs/heads/master@{#455758} Committed: https://chromium.googlesource.com/chromium/src/+/2da862c5f16c22f69358d30c4bd500b87dad91a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mthiesse
PTAL
3 years, 9 months ago (2017-03-09 15:42:38 UTC) #2
bshe
On 2017/03/09 15:42:38, mthiesse wrote: > PTAL lgtm
3 years, 9 months ago (2017-03-09 15:48:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744623002/1
3 years, 9 months ago (2017-03-09 15:49:58 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:24:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2da862c5f16c22f69358d30c4bd5...

Powered by Google App Engine
This is Rietveld 408576698