[object] Add Script::IsUserJavaScript().

[object] Add Script::IsUserJavaScript().

Extract script->type() == TYPE_NORMAL into 
a function. 

BUG=

Review-Url: https://codereview.chromium.org/2744613006
Cr-Commit-Position: refs/heads/master@{#43868}
Committed: https://chromium.googlesource.com/v8/v8/+/815d82376c1014f6af83b7a42407bb2e01fcd08c

[Franzi, 2017-03-11 10:03:26]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 10:03:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2017-03-11 10:17:46]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 10:17:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 10:19:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 10:19:20]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/18807)

[Franzi, 2017-03-11 10:28:45]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 10:28:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 10:30:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 10:30:20]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/22325)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36398)

[Franzi, 2017-03-11 10:35:59]

Description was changed from

==========
Delete unnecessary cast.

BUG=
==========

to

==========
[object] Add Script::IsUserJavaScript().

Extract script->type() == TYPE_NORMAL into 
a function. 

BUG=
==========

[Franzi, 2017-03-11 10:37:38]

Patchset #2 (id:20001) has been deleted

[Franzi, 2017-03-11 10:39:03]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 10:39:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 10:40:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 10:40:41]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/22326)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/22353)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/22244)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36399)

[Franzi, 2017-03-11 10:46:34]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 10:46:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 10:48:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 10:48:11]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/22329)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)

[Franzi, 2017-03-11 10:57:28]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 10:57:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2017-03-11 11:00:56]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 11:01:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2017-03-11 11:11:00]

franzih@chromium.org changed reviewers:
+ yangguo@google.com

[Franzi, 2017-03-11 11:11:00]

PTAL

[commit-bot: I haz the power, 2017-03-11 11:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 11:22:57]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-13 13:31:04]

yangguo@chromium.org changed reviewers:
+ ahaas@chromium.org, yangguo@chromium.org

[Yang, 2017-03-13 13:31:04]

lgtm. Adding Andreas for wasm.

[ahaas, 2017-03-13 13:32:16]

lgtm

[Franzi, 2017-03-16 09:28:36]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2017-03-16 09:28:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 09:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 09:55:08]

Failed to apply patch for src/debug/debug.cc:
While running git apply --index -p1;
  error: patch failed: src/debug/debug.cc:2026
  error: src/debug/debug.cc: patch does not apply

Patch:       src/debug/debug.cc
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index
5cff7f4a347fd74493ab13a5b0ed11a1686fdd94..cf40ab1f5b839e12ffeb04f6f2650b7df9e99669
100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -1979,7 +1979,7 @@ bool Debug::IsBlackboxed(Handle<SharedFunctionInfo>
shared) {
       DisableBreak no_recursive_break(this);
       DCHECK(shared->script()->IsScript());
       Handle<Script> script(Script::cast(shared->script()));
-      DCHECK(script->type() == i::Script::TYPE_NORMAL);
+      DCHECK(script->IsUserJavaScript());
       debug::Location start =
           GetDebugLocation(script, shared->start_position());
       debug::Location end = GetDebugLocation(script, shared->end_position());
@@ -2026,8 +2026,7 @@ void Debug::OnAsyncTaskEvent(debug::PromiseDebugActionType
type, int id,
 
 void Debug::ProcessCompileEvent(v8::DebugEvent event, Handle<Script> script) {
   if (ignore_events()) return;
-  if (script->type() != i::Script::TYPE_NORMAL &&
-      script->type() != i::Script::TYPE_WASM) {
+  if (!script->IsUserJavaScript() && script->type() != i::Script::TYPE_WASM) {
     return;
   }
   if (!debug_delegate_) return;

[Franzi, 2017-03-16 15:09:13]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2017-03-16 15:09:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 15:11:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 15:11:41]

Failed to apply patch for src/debug/debug.cc:
While running git apply --index -p1;
  error: patch failed: src/debug/debug.cc:2026
  error: src/debug/debug.cc: patch does not apply

Patch:       src/debug/debug.cc
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index
5cff7f4a347fd74493ab13a5b0ed11a1686fdd94..cf40ab1f5b839e12ffeb04f6f2650b7df9e99669
100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -1979,7 +1979,7 @@ bool Debug::IsBlackboxed(Handle<SharedFunctionInfo>
shared) {
       DisableBreak no_recursive_break(this);
       DCHECK(shared->script()->IsScript());
       Handle<Script> script(Script::cast(shared->script()));
-      DCHECK(script->type() == i::Script::TYPE_NORMAL);
+      DCHECK(script->IsUserJavaScript());
       debug::Location start =
           GetDebugLocation(script, shared->start_position());
       debug::Location end = GetDebugLocation(script, shared->end_position());
@@ -2026,8 +2026,7 @@ void Debug::OnAsyncTaskEvent(debug::PromiseDebugActionType
type, int id,
 
 void Debug::ProcessCompileEvent(v8::DebugEvent event, Handle<Script> script) {
   if (ignore_events()) return;
-  if (script->type() != i::Script::TYPE_NORMAL &&
-      script->type() != i::Script::TYPE_WASM) {
+  if (!script->IsUserJavaScript() && script->type() != i::Script::TYPE_WASM) {
     return;
   }
   if (!debug_delegate_) return;

[Franzi, 2017-03-16 15:35:56]

The CQ bit was checked by franzih@chromium.org

[Franzi, 2017-03-16 15:35:56]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2744613006/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-16 15:36:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 16:03:04]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489678556350010,
"parent_rev": "7de21c4d3b68976558879f126d83e86dc44c4f65", "commit_rev":
"815d82376c1014f6af83b7a42407bb2e01fcd08c"}

[commit-bot: I haz the power, 2017-03-16 16:03:11]

Description was changed from

==========
[object] Add Script::IsUserJavaScript().

Extract script->type() == TYPE_NORMAL into 
a function. 

BUG=
==========

to

==========
[object] Add Script::IsUserJavaScript().

Extract script->type() == TYPE_NORMAL into 
a function. 

BUG=

Review-Url: https://codereview.chromium.org/2744613006
Cr-Commit-Position: refs/heads/master@{#43868}
Committed:
https://chromium.googlesource.com/v8/v8/+/815d82376c1014f6af83b7a42407bb2e01f...
==========

[commit-bot: I haz the power, 2017-03-16 16:03:13]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/815d82376c1014f6af83b7a42407bb2e01f...