Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issue 2744613002: Use IdTargetObserver in SVGUseElement (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use IdTargetObserver in SVGUseElement Change SVGUseElement to use the observeTarget() helper from SVGURIReference. Since SVGUseElement has some additional requirements for its reference management, a more low-level observeTarget() variant is exposed. To facilitate this change, clearShadowTree() is renamed to clearResourceReference(), and the shadow tree tear-down is hoisted out of it. BUG=661598 Review-Url: https://codereview.chromium.org/2744613002 Cr-Commit-Position: refs/heads/master@{#455769} Committed: https://chromium.googlesource.com/chromium/src/+/9b88406d1a87dfeef593c6d1a91beb3a2b696391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -40 lines) Patch
M third_party/WebKit/Source/core/svg/SVGURIReference.h View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.cpp View 2 chunks +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 6 chunks +20 lines, -33 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 9 months ago (2017-03-09 14:54:48 UTC) #6
Stephen Chennney
lgtm
3 years, 9 months ago (2017-03-09 15:35:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744613002/1
3 years, 9 months ago (2017-03-09 16:43:06 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:48:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b88406d1a87dfeef593c6d1a91b...

Powered by Google App Engine
This is Rietveld 408576698