Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2744593004: Fix use-after-free in NavigationSimulator test util (Closed)

Created:
3 years, 9 months ago by Charlie Harrison
Modified:
3 years, 9 months ago
Reviewers:
clamy, jam
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use-after-free in NavigationSimulator test util This was causing ASAN/TSAN errors under PlzNavigate BUG=700098 Review-Url: https://codereview.chromium.org/2744593004 Cr-Commit-Position: refs/heads/master@{#455864} Committed: https://chromium.googlesource.com/chromium/src/+/f9a7108a65a43fafa4fa35fc208efb40503142f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/public/test/navigation_simulator.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Charlie Harrison
jam: this fixes the issue locally. PTAL. clamy: TBR
3 years, 9 months ago (2017-03-09 18:02:20 UTC) #4
jam
lgtm, thanks!
3 years, 9 months ago (2017-03-09 19:29:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744593004/1
3 years, 9 months ago (2017-03-09 19:33:21 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 21:16:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9a7108a65a43fafa4fa35fc208e...

Powered by Google App Engine
This is Rietveld 408576698