MD Settings: For some content types, make per-site exceptions read-only.

MD Settings: For some content types, make per-site exceptions read-only.

This CL makes MD Settings match old Options in terms of which content
types have exceptions that are read-only (from within Settings).

BUG=700118
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2744583004
Cr-Commit-Position: refs/heads/master@{#457151}
Committed: https://chromium.googlesource.com/chromium/src/+/62d32b16f0926c4c34c97deff4c0e6acb74a1bba

[tommycli, 2017-03-09 23:34:22]

Description was changed from

==========
MD Settings: For some content types, make per-site exceptions read-only.

This CL makes MD Settings match old Options in terms of which content
types have exceptions that are read-only (from within Settings).

BUG=700118
==========

to

==========
MD Settings: For some content types, make per-site exceptions read-only.

This CL makes MD Settings match old Options in terms of which content
types have exceptions that are read-only (from within Settings).

BUG=700118
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-03-09 23:37:00]

tommycli@chromium.org changed reviewers:
+ dschuyler@chromium.org, raymes@chromium.org

[tommycli, 2017-03-09 23:37:01]

dschuyler, raymes: PTAL.

This CL forbids editing of the exception list for certain content types -- to
match Old Options.

The old options list is defined here:
https://cs.chromium.org/chromium/src/chrome/browser/resources/options/content...

I didn't have to change zoom levels and USB in MD Settings, because those
already can't be edited.

[tommycli, 2017-03-09 23:37:35]

On 2017/03/09 23:37:01, tommycli wrote:
> dschuyler, raymes: PTAL.
> 
> This CL forbids editing of the exception list for certain content types -- to
> match Old Options.
> 
> The old options list is defined here:
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/options/content...
> 
> I didn't have to change zoom levels and USB in MD Settings, because those
> already can't be edited.

Screenie of how it looks when the list is read-only: http://imgur.com/a/i2XoN

[dschuyler, 2017-03-10 01:12:35]

lgtm

[tommycli, 2017-03-10 01:23:05]

On 2017/03/10 01:12:35, dschuyler wrote:
> lgtm

thanks!

[tommycli, 2017-03-10 01:23:10]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-03-10 01:23:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-03-10 02:34:35]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-03-15 17:50:36]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-03-15 17:51:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 18:51:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489600236987640, "parent_rev":
"30a67395e8cfccfd5954b9244440a7906d065563", "commit_rev":
"62d32b16f0926c4c34c97deff4c0e6acb74a1bba"}

[commit-bot: I haz the power, 2017-03-15 18:52:46]

Description was changed from

==========
MD Settings: For some content types, make per-site exceptions read-only.

This CL makes MD Settings match old Options in terms of which content
types have exceptions that are read-only (from within Settings).

BUG=700118
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: For some content types, make per-site exceptions read-only.

This CL makes MD Settings match old Options in terms of which content
types have exceptions that are read-only (from within Settings).

BUG=700118
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2744583004
Cr-Commit-Position: refs/heads/master@{#457151}
Committed:
https://chromium.googlesource.com/chromium/src/+/62d32b16f0926c4c34c97deff4c0...
==========

[commit-bot: I haz the power, 2017-03-15 18:52:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/62d32b16f0926c4c34c97deff4c0...