Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2744583002: Get rid of redundant #include "VisibleSelection.h" from EditCommand.h (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of redundant #include "VisibleSelection.h" from EditCommand.h This patch gets rid of include-directive for "VisibleSelection.h" from "EditCommand.h" to reduce source code size and faster compilation for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2744583002 Cr-Commit-Position: refs/heads/master@{#455934} Committed: https://chromium.googlesource.com/chromium/src/+/0a2a68937880d75c5860d528cb788f14d46923f3

Patch Set 1 : 2017-03-09T17:59:44 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/commands/EditCommand.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-09 09:10:35 UTC) #5
Xiaocheng
lgtm
3 years, 9 months ago (2017-03-09 19:12:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744583002/1
3 years, 9 months ago (2017-03-10 00:48:45 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 00:58:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a2a68937880d75c5860d528cb78...

Powered by Google App Engine
This is Rietveld 408576698