DevTools: [hosted mode] avoid exception in devtools_compatibility:addExtensions

DevTools: [hosted mode] avoid exception in devtools_compatibility:addExtensions

The addExtensions command gets sent on front-end relatively early,
when the onload event gets triggered.

However, in case of hosted mode, the load event happens before actual
InspectorFrontendHost initialization, since Runtime.js starts loading
and evaling all the dependencies by itself.

This patch protects from this race so that there's no annoying exception
thrown.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2744573002
Cr-Commit-Position: refs/heads/master@{#455993}
Committed: https://chromium.googlesource.com/chromium/src/+/6a70689503a8565c13b842657227421fab3a2145

[lushnikov, 2017-03-09 08:44:10]

please, take a look

[lushnikov, 2017-03-09 08:45:14]

please, take a look

[lushnikov, 2017-03-09 08:45:19]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 08:45:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 10:09:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 10:09:57]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-03-09 23:35:18]

lgtm

https://codereview.chromium.org/2744573002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js
(right):

https://codereview.chromium.org/2744573002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js:71: //
DevTools front-end. In case of DEBUG_DEVTOOLS/hosted mode, this
That's only in hosted mode.

[lushnikov, 2017-03-10 02:26:23]

Description was changed from

==========
DevTools: [hosted mode] avoid exception in devtools_compatibility:addExtensions

The addExtensions command gets sent on front-end relatively early,
when the onload event gets triggered.

However, in case of hosted mode or debug-devtools-mode, the
load event happens before actual InspectorFrontendHost initialization,
since Runtime.js starts loading and evaling all the dependencies by
itself.

This patch protects from this race so that there's no annoying exception
thrown.

BUG=none
R=dgozman
==========

to

==========
DevTools: [hosted mode] avoid exception in devtools_compatibility:addExtensions

The addExtensions command gets sent on front-end relatively early,
when the onload event gets triggered.

However, in case of hosted mode, the load event happens before actual
InspectorFrontendHost initialization, since Runtime.js starts loading
and evaling all the dependencies by itself.

This patch protects from this race so that there's no annoying exception
thrown.

BUG=none
R=dgozman
==========

[lushnikov, 2017-03-10 02:27:59]

https://codereview.chromium.org/2744573002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js
(right):

https://codereview.chromium.org/2744573002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js:71: //
DevTools front-end. In case of DEBUG_DEVTOOLS/hosted mode, this
On 2017/03/09 23:35:17, dgozman wrote:
> That's only in hosted mode.

Done.

[lushnikov, 2017-03-10 02:28:02]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-03-10 02:28:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2744573002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-03-10 02:28:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 04:21:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489112882361880,
"parent_rev": "09a524bf16691a0fd873d1d24edf04c8aae8874d", "commit_rev":
"6a70689503a8565c13b842657227421fab3a2145"}

[commit-bot: I haz the power, 2017-03-10 04:23:00]

Description was changed from

==========
DevTools: [hosted mode] avoid exception in devtools_compatibility:addExtensions

The addExtensions command gets sent on front-end relatively early,
when the onload event gets triggered.

However, in case of hosted mode, the load event happens before actual
InspectorFrontendHost initialization, since Runtime.js starts loading
and evaling all the dependencies by itself.

This patch protects from this race so that there's no annoying exception
thrown.

BUG=none
R=dgozman
==========

to

==========
DevTools: [hosted mode] avoid exception in devtools_compatibility:addExtensions

The addExtensions command gets sent on front-end relatively early,
when the onload event gets triggered.

However, in case of hosted mode, the load event happens before actual
InspectorFrontendHost initialization, since Runtime.js starts loading
and evaling all the dependencies by itself.

This patch protects from this race so that there's no annoying exception
thrown.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2744573002
Cr-Commit-Position: refs/heads/master@{#455993}
Committed:
https://chromium.googlesource.com/chromium/src/+/6a70689503a8565c13b842657227...
==========

[commit-bot: I haz the power, 2017-03-10 04:23:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6a70689503a8565c13b842657227...