Remove RenderWidget::SetBackground, change IPC to pass a bool.

Remove RenderWidget::SetBackground, change IPC to pass a bool.

The ViewMsg_SetBackground message currently passes an SkBitmap that
signals if the RenderView should have an opaque background or not. We
can use a bool instead to convey this data.

Rename the ViewMsg_SetBackground to ViewMsg_SetBackgroundOpaque as well
as the Set/GetBackground methods on the various RenderWidget/View
classes.

RenderWidget itself no longer needs to know about the background opaque
changes.

R=kenrb, piman
BUG=362164
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269953

[danakj, 2014-05-06 23:44:07]

piman: please review
kenrb: view_messages.h

[danakj, 2014-05-06 23:44:39]

+mek for apps/

[piman, 2014-05-07 00:29:55]

Did you mean to remove RenderWidget::SetBackground in this CL?

https://codereview.chromium.org/274453002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/274453002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_android.cc:673:
host_->Send(new ViewMsg_SetBackgroundOpaque(host_->GetRoutingID(), opaque));
nit: host_->SetBackgroundOpaque(opaque) ? That way there is a single sender of
this message.

https://codereview.chromium.org/274453002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/274453002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_mac.mm:2033:
render_widget_host_->Send(new ViewMsg_SetBackgroundOpaque(
nit: same here, render_widget_host_->SetBackgroundOpaque(opaque); ?

[kenrb, 2014-05-07 13:46:19]

lgtm for IPC change

[Marijn Kruisselbrink, 2014-05-07 16:37:21]

apps/ lgtm

[danakj, 2014-05-07 17:08:17]

Oh, ya I missed a commit on upload, thanks :)

https://codereview.chromium.org/274453002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/274453002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_android.cc:673:
host_->Send(new ViewMsg_SetBackgroundOpaque(host_->GetRoutingID(), opaque));
On 2014/05/07 00:29:56, piman wrote:
> nit: host_->SetBackgroundOpaque(opaque) ? That way there is a single sender of
> this message.

Done.

https://codereview.chromium.org/274453002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/274453002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_mac.mm:2033:
render_widget_host_->Send(new ViewMsg_SetBackgroundOpaque(
On 2014/05/07 00:29:56, piman wrote:
> nit: same here, render_widget_host_->SetBackgroundOpaque(opaque); ?

Done.

[danakj, 2014-05-07 17:10:02]

PTAL

[piman, 2014-05-07 21:01:57]

LGTM!

[danakj, 2014-05-07 21:07:47]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-07 21:10:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/40001

[danakj, 2014-05-07 21:40:12]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-07 21:42:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/60001

[commit-bot: I haz the power, 2014-05-08 14:43:28]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-08 15:35:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 15:35:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[danakj, 2014-05-08 15:36:53]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-08 15:41:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/80001

[danakj, 2014-05-08 15:44:01]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-08 15:46:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/2

[danakj, 2014-05-08 17:03:18]

+oshima for chrome/browser/chromeos

[danakj, 2014-05-09 15:41:37]

oshima: ping

[oshima, 2014-05-09 15:56:20]

lgtm

[danakj, 2014-05-09 16:53:35]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-09 16:54:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/110001

[commit-bot: I haz the power, 2014-05-09 17:13:03]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-09 17:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 17:19:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[danakj, 2014-05-09 17:20:26]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-09 17:26:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/110001

[commit-bot: I haz the power, 2014-05-09 17:38:20]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-09 17:45:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 17:45:20]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[danakj, 2014-05-09 17:46:54]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-09 17:50:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/120001

[commit-bot: I haz the power, 2014-05-09 20:41:00]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-09 23:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 23:00:56]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[danakj, 2014-05-09 23:04:21]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-09 23:06:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/140001

[commit-bot: I haz the power, 2014-05-10 04:09:52]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-10 05:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 05:14:15]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[danakj, 2014-05-12 14:41:47]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-12 14:42:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/140001

[commit-bot: I haz the power, 2014-05-12 16:21:44]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[danakj, 2014-05-12 16:34:53]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-05-12 16:41:39]

I'm unable to include render_widget_host_view_mac.h from
render_widget_host_unittest.cc and compile. It looks to assume it's only
included from .mm files. So, I went back to ifdefing out the SetBackground test
on Mac as before.

[danakj, 2014-05-12 16:41:46]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-12 16:42:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/160001

[danakj, 2014-05-12 17:09:46]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-12 17:11:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/160001

[commit-bot: I haz the power, 2014-05-12 21:22:26]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-12 22:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-12 22:38:34]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[danakj, 2014-05-12 22:45:23]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-12 22:47:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/274453002/160001

[commit-bot: I haz the power, 2014-05-13 01:24:51]

Change committed as 269953