Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 274453002: Remove RenderWidget::SetBackground, change IPC to pass a bool. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_android.h" 5 #include "content/browser/renderer_host/render_widget_host_view_android.h"
6 6
7 #include <android/bitmap.h> 7 #include <android/bitmap.h>
8 8
9 #include "base/android/sys_utils.h" 9 #include "base/android/sys_utils.h"
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 void RenderWidgetHostViewAndroid::SelectionRootBoundsChanged( 661 void RenderWidgetHostViewAndroid::SelectionRootBoundsChanged(
662 const gfx::Rect& bounds) { 662 const gfx::Rect& bounds) {
663 if (content_view_core_) { 663 if (content_view_core_) {
664 content_view_core_->OnSelectionRootBoundsChanged(bounds); 664 content_view_core_->OnSelectionRootBoundsChanged(bounds);
665 } 665 }
666 } 666 }
667 667
668 void RenderWidgetHostViewAndroid::ScrollOffsetChanged() { 668 void RenderWidgetHostViewAndroid::ScrollOffsetChanged() {
669 } 669 }
670 670
671 void RenderWidgetHostViewAndroid::SetBackground(const SkBitmap& background) { 671 void RenderWidgetHostViewAndroid::SetBackgroundOpaque(bool opaque) {
672 RenderWidgetHostViewBase::SetBackground(background); 672 RenderWidgetHostViewBase::SetBackgroundOpaque(opaque);
673 host_->Send(new ViewMsg_SetBackground(host_->GetRoutingID(), background)); 673 host_->Send(new ViewMsg_SetBackgroundOpaque(host_->GetRoutingID(), opaque));
piman 2014/05/07 00:29:56 nit: host_->SetBackgroundOpaque(opaque) ? That way
danakj 2014/05/07 17:08:17 Done.
674 } 674 }
675 675
676 void RenderWidgetHostViewAndroid::CopyFromCompositingSurface( 676 void RenderWidgetHostViewAndroid::CopyFromCompositingSurface(
677 const gfx::Rect& src_subrect, 677 const gfx::Rect& src_subrect,
678 const gfx::Size& dst_size, 678 const gfx::Size& dst_size,
679 const base::Callback<void(bool, const SkBitmap&)>& callback, 679 const base::Callback<void(bool, const SkBitmap&)>& callback,
680 const SkBitmap::Config bitmap_config) { 680 const SkBitmap::Config bitmap_config) {
681 if (!IsReadbackConfigSupported(bitmap_config)) { 681 if (!IsReadbackConfigSupported(bitmap_config)) {
682 callback.Run(false, SkBitmap()); 682 callback.Run(false, SkBitmap());
683 return; 683 return;
(...skipping 772 matching lines...) Expand 10 before | Expand all | Expand 10 after
1456 results->availableRect = display.work_area(); 1456 results->availableRect = display.work_area();
1457 results->deviceScaleFactor = display.device_scale_factor(); 1457 results->deviceScaleFactor = display.device_scale_factor();
1458 results->orientationAngle = display.RotationAsDegree(); 1458 results->orientationAngle = display.RotationAsDegree();
1459 gfx::DeviceDisplayInfo info; 1459 gfx::DeviceDisplayInfo info;
1460 results->depth = info.GetBitsPerPixel(); 1460 results->depth = info.GetBitsPerPixel();
1461 results->depthPerComponent = info.GetBitsPerComponent(); 1461 results->depthPerComponent = info.GetBitsPerComponent();
1462 results->isMonochrome = (results->depthPerComponent == 0); 1462 results->isMonochrome = (results->depthPerComponent == 0);
1463 } 1463 }
1464 1464
1465 } // namespace content 1465 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698