Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2744513003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (signin). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=mlerman@chromium.org Review-Url: https://codereview.chromium.org/2744513003 Cr-Commit-Position: refs/heads/master@{#456709} Committed: https://chromium.googlesource.com/chromium/src/+/6f78a7a80b37afd562cd45f57c1b9a4a3ff711e1

Patch Set 1 #

Total comments: 2

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/signin/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-09 22:57:33 UTC) #2
msarda
https://codereview.chromium.org/2744513003/diff/1/chrome/browser/signin/OWNERS File chrome/browser/signin/OWNERS (right): https://codereview.chromium.org/2744513003/diff/1/chrome/browser/signin/OWNERS#newcode17 chrome/browser/signin/OWNERS:17: # COMPONENT: UI>ProximityAuth # TEAM: chrome-signin@chromium.org (I doubt this ...
3 years, 9 months ago (2017-03-10 14:21:26 UTC) #4
ymzhang1
https://codereview.chromium.org/2744513003/diff/1/chrome/browser/signin/OWNERS File chrome/browser/signin/OWNERS (right): https://codereview.chromium.org/2744513003/diff/1/chrome/browser/signin/OWNERS#newcode17 chrome/browser/signin/OWNERS:17: # COMPONENT: UI>ProximityAuth On 2017/03/10 14:21:26, msarda wrote: > ...
3 years, 9 months ago (2017-03-10 18:06:06 UTC) #5
ymzhang1
mlerman@, msarda@, rogerta@: Could (one of) you please lgtm this change in chrome/browser/signin/OWNERS? Thanks.
3 years, 9 months ago (2017-03-13 21:58:44 UTC) #6
Mike Lerman
On 2017/03/13 21:58:44, ymzhang1 wrote: > mlerman@, msarda@, rogerta@: > > Could (one of) you ...
3 years, 9 months ago (2017-03-14 00:50:39 UTC) #7
msarda
lgtm
3 years, 9 months ago (2017-03-14 03:02:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744513003/20001
3 years, 9 months ago (2017-03-14 15:36:15 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 15:46:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f78a7a80b37afd562cd45f57c1b...

Powered by Google App Engine
This is Rietveld 408576698