Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2744493002: [ash-md] Added darkness blending to the colorized shelf. (Closed)

Created:
3 years, 9 months ago by bruthig
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Added darkness blending to the colorized shelf. Added a blend between the color extracted from the wallpaper image and black before applying it to the shelf. This is still experimental work behind the --ash-shelf-color flag. BUG=595010 Review-Url: https://codereview.chromium.org/2744493002 Cr-Commit-Position: refs/heads/master@{#455665} Committed: https://chromium.googlesource.com/chromium/src/+/6aebe9946513bfeea68b2bc21e4c98bae54fc556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M ash/common/shelf/shelf_background_animator.cc View 1 chunk +26 lines, -12 lines 0 comments Download
M ash/common/shelf/shelf_constants.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/common/shelf/shelf_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bruthig
sky@, can you PTAL?
3 years, 9 months ago (2017-03-09 00:51:20 UTC) #4
sky
LGTM
3 years, 9 months ago (2017-03-09 03:32:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744493002/1
3 years, 9 months ago (2017-03-09 04:07:33 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 04:27:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6aebe9946513bfeea68b2bc21e4c...

Powered by Google App Engine
This is Rietveld 408576698