update fasta scanner to always generate INDEX or INDEX_EQ tokens

update fasta scanner to always generate INDEX or INDEX_EQ tokens

* updated scanner to always generate INDEX and INDEX_EQ for "[]" and "[]="
* updated parser to generate ErrorKind.EmptyOptionalParameterList when "[]" detected
* updated unparser to prevent INDEX token from being generated as [][]

Fix https://github.com/dart-lang/sdk/issues/28665

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/b8d318e94edf20f2b285eaf3e522d09d9290e456

[danrubel, 2017-03-09 01:49:54]

Description was changed from

==========
update fasta scanner to always generate INDEX or INDEX_EQ tokens

* updated scanner to always generate INDEX and INDEX_EQ for "[]" and "[]="
* updated parser to generate ErrorKind.EmptyOptionalParameterList when "[]"
detected
* updated unparser to prevent INDEX token from being generated as [][]
==========

to

==========
update fasta scanner to always generate INDEX or INDEX_EQ tokens

* updated scanner to always generate INDEX and INDEX_EQ for "[]" and "[]="
* updated parser to generate ErrorKind.EmptyOptionalParameterList when "[]"
detected
* updated unparser to prevent INDEX token from being generated as [][]

Fix https://github.com/dart-lang/sdk/issues/28665
==========

[danrubel, 2017-03-09 01:50:09]

danrubel@google.com changed reviewers:
+ ahe@google.com, paulberry@google.com

[ahe, 2017-03-09 12:45:19]

lgtm

OMG, I can't believe it was that simple. I wish we had done that years ago :-)

https://codereview.chromium.org/2744463003/diff/1/pkg/compiler/lib/src/tree/u...
File pkg/compiler/lib/src/tree/unparser.dart (right):

https://codereview.chromium.org/2744463003/diff/1/pkg/compiler/lib/src/tree/u...
pkg/compiler/lib/src/tree/unparser.dart:389: // if "[]" then beginToken ==
endToken ... only write beginToken
Change this comment to be a complete sentence. In particular, start with an
uppercase letter and end with a period.

https://codereview.chromium.org/2744463003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2744463003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:496:
reportRecoverableError(token,
Nice. This should work well with endFormalParameters being called with
parameterCount == 0 below.

The new error may change the status of some tests. Be sure to test -cdartk:

./tools/build.py -mrelease runtime_kernel && ./tools/test.py -mrelease -cdartk
co19 language kernel --time -pcolor --report --failure-summary -j16

You may need to update these files:

tests/co19/co19-kernel.status
tests/kernel/kernel.status
tests/language/language_kernel.status

[danrubel, 2017-03-12 18:19:31]

Description was changed from

==========
update fasta scanner to always generate INDEX or INDEX_EQ tokens

* updated scanner to always generate INDEX and INDEX_EQ for "[]" and "[]="
* updated parser to generate ErrorKind.EmptyOptionalParameterList when "[]"
detected
* updated unparser to prevent INDEX token from being generated as [][]

Fix https://github.com/dart-lang/sdk/issues/28665
==========

to

==========
update fasta scanner to always generate INDEX or INDEX_EQ tokens

* updated scanner to always generate INDEX and INDEX_EQ for "[]" and "[]="
* updated parser to generate ErrorKind.EmptyOptionalParameterList when "[]"
detected
* updated unparser to prevent INDEX token from being generated as [][]

Fix https://github.com/dart-lang/sdk/issues/28665

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b8d318e94edf20f2b285eaf3e522d09d9290e456
==========

[danrubel, 2017-03-12 18:19:33]

Committed patchset #2 (id:20001) manually as
b8d318e94edf20f2b285eaf3e522d09d9290e456 (presubmit successful).

[danrubel, 2017-03-12 22:45:11]

On 2017/03/09 12:45:19, ahe wrote:
> lgtm
> 
> OMG, I can't believe it was that simple. I wish we had done that years ago :-)

Nope... not quite so simple.
Reverting and digging further.

[danrubel, 2017-03-13 14:52:52]

Description was changed from

==========
update fasta scanner to always generate INDEX or INDEX_EQ tokens

* updated scanner to always generate INDEX and INDEX_EQ for "[]" and "[]="
* updated parser to generate ErrorKind.EmptyOptionalParameterList when "[]"
detected
* updated unparser to prevent INDEX token from being generated as [][]

Fix https://github.com/dart-lang/sdk/issues/28665

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b8d318e94edf20f2b285eaf3e522d09d9290e456
==========

to

==========
update fasta scanner to always generate INDEX or INDEX_EQ tokens

* updated scanner to always generate INDEX and INDEX_EQ for "[]" and "[]="
* updated parser to generate ErrorKind.EmptyOptionalParameterList when "[]"
detected
* updated unparser to prevent INDEX token from being generated as [][]

Fix https://github.com/dart-lang/sdk/issues/28665

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b8d318e94edf20f2b285eaf3e522d09d9290e456
==========

[danrubel, 2017-03-13 14:56:44]

Take 2 https://codereview.chromium.org/2747683003

https://codereview.chromium.org/2744463003/diff/1/pkg/compiler/lib/src/tree/u...
File pkg/compiler/lib/src/tree/unparser.dart (right):

https://codereview.chromium.org/2744463003/diff/1/pkg/compiler/lib/src/tree/u...
pkg/compiler/lib/src/tree/unparser.dart:389: // if "[]" then beginToken ==
endToken ... only write beginToken
On 2017/03/09 12:45:18, ahe wrote:
> Change this comment to be a complete sentence. In particular, start with an
> uppercase letter and end with a period.

Done.
https://codereview.chromium.org/2747683003