Handle large rects better.

ui/gfx/geometry/rect.h

Index: ui/gfx/geometry/rect.h
diff --git a/ui/gfx/geometry/rect.h b/ui/gfx/geometry/rect.h
index 8c37e8eeabd11cafdc2c0f43cad20bbac1f9f0f3..ea61b9f15c14872f1fefdeaaff31ca083e2ff701 100644
--- a/ui/gfx/geometry/rect.h
+++ b/ui/gfx/geometry/rect.h
@@ -110,6 +110,9 @@ class GFX_EXPORT Rect {
     set_height(height);
   }
 
+  // Safely(heuristically) take min and max to the internal representation.

[danakj, 2017/03/28 20:40:34]

I get what this is talking about but I'm not really sure what the comment is
saying exactly. I think SetByBounds() is pretty self explanatory and how its
implemented is a detail, I would drop the comment

[Peter Mayo, 2017/03/29 18:49:26]

I wanted it there to highlight to devs that there it doesn't work to just pass
(top, left, right-left, bottom-top) to SetRect, nor to assert equality after
calling this.  I'm OK with dropping it, but I think it incrementally improved
velocity.

+  void SetByBounds(int left, int right, int top, int bottom);

[danakj, 2017/03/28 20:40:34]

Can you reorder these as left, top, right, bottom? That will match SkRect, and
then they are clockwise. I wanted to find one that is most common but SkRect,
gfx::Insets, and css margins all do a different ordering. At least we can match
one of them here instead of making a 4th ordering.

[Peter Mayo, 2017/03/29 18:49:25]

I kind of like Skia's practice of putting the order in the name, tickling in
place recognition of the order.  It would look out pf place in gfx at the
moment, especially the constructor.

Just reordered.

+
   // Shrink the rectangle by a horizontal and vertical distance on all sides.
   void Inset(int horizontal, int vertical) {
     Inset(horizontal, vertical, horizontal, vertical);