Handle large rects better.

ui/gfx/geometry/rect.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines a simple integer rectangle class.  The containment semantics
 // are array-like; that is, the coordinate (x, y) is considered to be
 // contained by the rectangle, but the coordinate (x + width, y) is not.
 // The class will happily let you create malformed rectangles (that is,
 // rectangles with negative width and/or height), but there will be assertions
 // in the operations (such as Contains()) to complain in this case.
@@ skipping 92 matching lines @@
 
   Vector2d OffsetFromOrigin() const { return Vector2d(x(), y()); }
 
   void SetRect(int x, int y, int width, int height) {
     origin_.SetPoint(x, y);
     // Ensure that width and height remain valid.
     set_width(width);
     set_height(height);
   }
 
+  // Safely(heuristically) take min and max to the internal representation.

[danakj, 2017/03/28 20:40:34]

I get what this is talking about but I'm not really sure what the comment is
saying exactly. I think SetByBounds() is pretty self explanatory and how its
implemented is a detail, I would drop the comment

[Peter Mayo, 2017/03/29 18:49:26]

I wanted it there to highlight to devs that there it doesn't work to just pass
(top, left, right-left, bottom-top) to SetRect, nor to assert equality after
calling this.  I'm OK with dropping it, but I think it incrementally improved
velocity.

+  void SetByBounds(int left, int right, int top, int bottom);

[danakj, 2017/03/28 20:40:34]

Can you reorder these as left, top, right, bottom? That will match SkRect, and
then they are clockwise. I wanted to find one that is most common but SkRect,
gfx::Insets, and css margins all do a different ordering. At least we can match
one of them here instead of making a 4th ordering.

[Peter Mayo, 2017/03/29 18:49:25]

I kind of like Skia's practice of putting the order in the name, tickling in
place recognition of the order.  It would look out pf place in gfx at the
moment, especially the constructor.

Just reordered.

+
   // Shrink the rectangle by a horizontal and vertical distance on all sides.
   void Inset(int horizontal, int vertical) {
     Inset(horizontal, vertical, horizontal, vertical);
   }
 
   // Shrink the rectangle by the given insets.
   void Inset(const Insets& insets);
 
   // Shrink the rectangle by the specified amount on each side.
   void Inset(int left, int top, int right, int bottom);
@@ skipping 213 matching lines @@
 }
 
 // This is declared here for use in gtest-based unit tests but is defined in
 // the //ui/gfx:test_support target. Depend on that to use this in your unit
 // test. This should not be used in production code - call ToString() instead.
 void PrintTo(const Rect& rect, ::std::ostream* os);
 
 }  // namespace gfx
 
 #endif  // UI_GFX_GEOMETRY_RECT_H_