[devil] Provide device.GetApplicationPids()

[devil] Provide device.GetApplicationPids()

A convenient method for clients to get PIDs when they know the exact
application (package) name of the process they want to get, without
having to inspect and validate the return value of GetPids().

Also provides an |at_most_one| option to raise an exception if many
PIDs are found but at most one was expected.

BUG=catapult:#3378

Review-Url: https://codereview.chromium.org/2744373003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7da88470e422e865aded98d9d5ff41baeb290af7

[perezju, 2017-03-14 13:37:49]

perezju@chromium.org changed reviewers:
+ jbudorick@chromium.org

[perezju, 2017-03-14 13:37:49]

Let me know what you think.

https://codereview.chromium.org/2744373003/diff/1/devil/devil/android/device_...
File devil/devil/android/device_utils.py (right):

https://codereview.chromium.org/2744373003/diff/1/devil/devil/android/device_...
devil/devil/android/device_utils.py:2144: def GetPids(self, process_name=None,
timeout=None, retries=None):
Some clients, e.g. [1], would like to get the full list of PIDs. This also
worked before (passing '' as process_name) but let's make the fact that it's
supported more explicit.

[1]:
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/...

https://codereview.chromium.org/2744373003/diff/1/devil/devil/android/device_...
devil/devil/android/device_utils.py:2189: if process_name in process and pid !=
'PID':
last bit needed to skip over the header in ps output

[perezju, 2017-03-17 10:51:48]

perezju@chromium.org changed reviewers:
+ mikecase@chromium.org

[jbudorick, 2017-03-17 15:50:30]

The changes to GetPids seem reasonable.

https://codereview.chromium.org/2744373003/diff/1/devil/devil/android/device_...
File devil/devil/android/device_utils.py (right):

https://codereview.chromium.org/2744373003/diff/1/devil/devil/android/device_...
devil/devil/android/device_utils.py:2195: def GetApplicationPids(self,
process_name, at_most_one=False, **kwargs):
Who would be the clients for this?

[perezju, 2017-03-17 16:03:08]

https://codereview.chromium.org/2744373003/diff/1/devil/devil/android/device_...
File devil/devil/android/device_utils.py (right):

https://codereview.chromium.org/2744373003/diff/1/devil/devil/android/device_...
devil/devil/android/device_utils.py:2195: def GetApplicationPids(self,
process_name, at_most_one=False, **kwargs):
On 2017/03/17 15:50:30, jbudorick wrote:
> Who would be the clients for this?

Most of them. Rationale and a few examples:
https://github.com/catapult-project/catapult/issues/3378

[jbudorick, 2017-03-17 16:14:08]

lgtm

https://codereview.chromium.org/2744373003/diff/1/devil/devil/android/device_...
File devil/devil/android/device_utils.py (right):

https://codereview.chromium.org/2744373003/diff/1/devil/devil/android/device_...
devil/devil/android/device_utils.py:2195: def GetApplicationPids(self,
process_name, at_most_one=False, **kwargs):
On 2017/03/17 16:03:08, perezju wrote:
> On 2017/03/17 15:50:30, jbudorick wrote:
> > Who would be the clients for this?
> 
> Most of them. Rationale and a few examples:
> https://github.com/catapult-project/catapult/issues/3378

Makes sense.

[perezju, 2017-03-17 16:24:08]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-03-17 16:24:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 16:47:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489767848710900, "parent_rev":
"689eddc13b0ffd70c14cf41608085b9c249ba4c6", "commit_rev":
"7da88470e422e865aded98d9d5ff41baeb290af7"}

[commit-bot: I haz the power, 2017-03-17 16:47:06]

Description was changed from

==========
[devil] Provide device.GetApplicationPids()

A convenient method for clients to get PIDs when they know the exact
application (package) name of the process they want to get, without
having to inspect and validate the return value of GetPids().

Also provides an |at_most_one| option to raise an exception if many
PIDs are found but at most one was expected.

BUG=catapult:#3378
==========

to

==========
[devil] Provide device.GetApplicationPids()

A convenient method for clients to get PIDs when they know the exact
application (package) name of the process they want to get, without
having to inspect and validate the return value of GetPids().

Also provides an |at_most_one| option to raise an exception if many
PIDs are found but at most one was expected.

BUG=catapult:#3378

Review-Url: https://codereview.chromium.org/2744373003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-03-17 16:47:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...