Add V8Ignition field-trial.

Add V8Ignition field-trial.

BUG=692409
Review-Url: https://codereview.chromium.org/2744293002
Cr-Commit-Position: refs/heads/master@{#456701}
Committed: https://chromium.googlesource.com/chromium/src/+/df3e4b2a5dbc59b8707015f1a10492202ff47a1b

[rmcilroy, 2017-03-13 16:22:41]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 16:23:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2017-03-13 16:23:38]

rmcilroy@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rmcilroy, 2017-03-13 16:23:38]

Robert, PTAL, thanks.

Stephane, FYI.

[rkaplow, 2017-03-13 17:10:06]

https://codereview.chromium.org/2744293002/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config.json (right):

https://codereview.chromium.org/2744293002/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config.json:2876: "name": "Future"
this only can test one, so I would add jsut Future here (assuming that's the
main feature being tested)

[commit-bot: I haz the power, 2017-03-13 17:13:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 17:13:39]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2017-03-14 09:57:44]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[rmcilroy, 2017-03-14 09:57:49]

https://codereview.chromium.org/2744293002/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config.json (right):

https://codereview.chromium.org/2744293002/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config.json:2876: "name": "Future"
On 2017/03/13 17:10:06, rkaplow (slow) wrote:
> this only can test one, so I would add jsut Future here (assuming that's the
> main feature being tested)

Done.

[commit-bot: I haz the power, 2017-03-14 09:58:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 10:34:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 10:34:48]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-03-14 14:30:30]

lgtm

[rmcilroy, 2017-03-14 14:47:02]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2017-03-14 14:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 14:50:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489502822025500,
"parent_rev": "bb87d2a62e732b34bcb0fdbf79fa6bbaf5588ed3", "commit_rev":
"df3e4b2a5dbc59b8707015f1a10492202ff47a1b"}

[commit-bot: I haz the power, 2017-03-14 14:51:34]

Description was changed from

==========
Add V8Ignition field-trial.

BUG=692409
==========

to

==========
Add V8Ignition field-trial.

BUG=692409

Review-Url: https://codereview.chromium.org/2744293002
Cr-Commit-Position: refs/heads/master@{#456701}
Committed:
https://chromium.googlesource.com/chromium/src/+/df3e4b2a5dbc59b8707015f1a104...
==========

[commit-bot: I haz the power, 2017-03-14 14:51:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/df3e4b2a5dbc59b8707015f1a104...

[chromium-reviews, 2017-03-14 15:48:29]

Guys I'm sorry but this CL was missing the "enable_features" directive. 
With the feature API, the feature needs to be specified in addition to the 
experiment name...

Rob: it's at least the second time something like this happens, I wonder 
what we could do to avoid this...

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.