[typedarrays] Implement %TypedArray%.prototype.lastIndexOf in C++

[typedarrays] Implement %TypedArray%.prototype.lastIndexOf in C++

- Implement C++ builtins and ElementsAccessor for
  %TypedArray%.prototype.lastIndexOf
- Remove TypedArrayLastIndexOf in src/js/typedarray.js
- Combine InnerArrayLastIndexOf and ArrayLastIndexOf in src/js/array.js

BUG=v8:5929
Review-Url: https://codereview.chromium.org/2744283002
Cr-Commit-Position: refs/heads/master@{#43870}
Committed: https://chromium.googlesource.com/v8/v8/+/da1bddcd75319d65e98e0eaacbe7904228f48cbc

[Choongwoo Han, 2017-03-13 14:41:37]

Description was changed from

==========
[typedarrays] Implement %TypedArray%.prototype.lastIndexOf in C++

- Implement C++ builtins and ElementsAccessor for
  %TypedArray%.prototype.lastIndexOf
- Remove TypedArrayLastIndexOf in src/js/typedarray.js
- Combine InnerArrayLastIndexOf and ArrayLastIndexOf in src/js/array.js

BUG=v8:5929
==========

to

==========
[typedarrays] Implement %TypedArray%.prototype.lastIndexOf in C++

- Implement C++ builtins and ElementsAccessor for
  %TypedArray%.prototype.lastIndexOf
- Remove TypedArrayLastIndexOf in src/js/typedarray.js
- Combine InnerArrayLastIndexOf and ArrayLastIndexOf in src/js/array.js

BUG=v8:5929
==========

[Choongwoo Han, 2017-03-13 14:41:37]

cwhan.tunz@gmail.com changed reviewers:
+ bmeurer@chromium.org, caitp@igalia.com, cbruni@chromium.org

[Choongwoo Han, 2017-03-13 14:41:47]

PTAL

[Camillo Bruni, 2017-03-14 09:58:21]

lgtm

https://codereview.chromium.org/2744283002/diff/1/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/2744283002/diff/1/src/elements.cc#newcode2936
src/elements.cc:2936: DisallowHeapAllocation no_gc;
I think we can just do
DCHECK(WasNeutered(*receiver));
in the elements accessor, given that all operations in here are side-effect
free.

[Choongwoo Han, 2017-03-14 16:12:31]

https://codereview.chromium.org/2744283002/diff/1/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/2744283002/diff/1/src/elements.cc#newcode2936
src/elements.cc:2936: DisallowHeapAllocation no_gc;
On 2017/03/14 09:58:21, Camillo Bruni wrote:
> I think we can just do
> DCHECK(WasNeutered(*receiver));
> in the elements accessor, given that all operations in here are side-effect
> free.

Done.

[Choongwoo Han, 2017-03-14 16:46:30]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 16:46:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 16:50:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 16:50:32]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24100)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/24189)

[Choongwoo Han, 2017-03-14 16:57:46]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 16:57:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 17:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 17:02:41]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Choongwoo Han, 2017-03-14 17:28:40]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 17:28:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 17:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 17:49:11]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/22515)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/18996)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Choongwoo Han, 2017-03-14 18:07:21]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 18:07:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 18:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 18:30:40]

Dry run: This issue passed the CQ dry run.

[Choongwoo Han, 2017-03-15 05:41:46]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 05:41:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 06:06:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 06:06:47]

Dry run: This issue passed the CQ dry run.

[Choongwoo Han, 2017-03-15 06:19:11]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 06:19:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 06:42:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 06:42:12]

Dry run: This issue passed the CQ dry run.

[Choongwoo Han, 2017-03-15 06:55:22]

There are additional minor changes and bug fixes.

- Use `do while` to iterate elements. (and use uint32_t for indexing)
- Correct negative indexing: Upper bound is len -1, and add `len` for negative
indexing.
- Correct integral value check (and add testcases for finding an index of
infinite values)
- fix some compile issues

[Choongwoo Han, 2017-03-16 15:59:39]

The CQ bit was checked by cwhan.tunz@gmail.com

[Choongwoo Han, 2017-03-16 15:59:39]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2744283002/#ps120001
(title: "Correct integral value check")

[commit-bot: I haz the power, 2017-03-16 15:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 16:28:00]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489679979019710,
"parent_rev": "17ac7c5f4d712c914030e1fb7247d2083b04b929", "commit_rev":
"da1bddcd75319d65e98e0eaacbe7904228f48cbc"}

[commit-bot: I haz the power, 2017-03-16 16:28:06]

Description was changed from

==========
[typedarrays] Implement %TypedArray%.prototype.lastIndexOf in C++

- Implement C++ builtins and ElementsAccessor for
  %TypedArray%.prototype.lastIndexOf
- Remove TypedArrayLastIndexOf in src/js/typedarray.js
- Combine InnerArrayLastIndexOf and ArrayLastIndexOf in src/js/array.js

BUG=v8:5929
==========

to

==========
[typedarrays] Implement %TypedArray%.prototype.lastIndexOf in C++

- Implement C++ builtins and ElementsAccessor for
  %TypedArray%.prototype.lastIndexOf
- Remove TypedArrayLastIndexOf in src/js/typedarray.js
- Combine InnerArrayLastIndexOf and ArrayLastIndexOf in src/js/array.js

BUG=v8:5929

Review-Url: https://codereview.chromium.org/2744283002
Cr-Commit-Position: refs/heads/master@{#43870}
Committed:
https://chromium.googlesource.com/v8/v8/+/da1bddcd75319d65e98e0eaacbe7904228f...
==========

[commit-bot: I haz the power, 2017-03-16 16:28:07]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/da1bddcd75319d65e98e0eaacbe7904228f...

[cbruni, 2017-03-16 20:47:35]

cbruni@google.com changed reviewers:
+ cbruni@google.com

[cbruni, 2017-03-16 20:47:36]

You should wait for the other reviewers to LGTM as well before landing.

[Choongwoo Han, 2017-03-17 07:30:05]

On 2017/03/16 20:47:36, cbruni wrote:
> You should wait for the other reviewers to LGTM as well before landing.

Sorry for that. I was too hasty, and it was a wrong decision. Commonly, do I
need to wait LGTM from all reviewers? I'll be careful next time. Please revert
this commit if needed.