[Doodle] Cache the DoodleConfig in prefs

[Doodle] Cache the DoodleConfig in prefs

BUG=690467
Review-Url: https://codereview.chromium.org/2744253002
Cr-Commit-Position: refs/heads/master@{#456658}
Committed: https://chromium.googlesource.com/chromium/src/+/76ee635828f448c9f1a873ec8a72406815cb4d12

[Marc Treib, 2017-03-13 13:03:30]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 13:03:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-03-13 13:05:40]

treib@chromium.org changed reviewers:
+ fhorschig@chromium.org

[Marc Treib, 2017-03-13 13:05:41]

Finally, the one that spawned all the yak shaving. PTAL!

[fhorschig, 2017-03-13 14:00:29]

Great to see and lgtm

[Marc Treib, 2017-03-13 14:02:55]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2017-03-13 14:02:55]

+bauerb for new dependency on components/prefs as well as committer's approval.
PTAL!

[commit-bot: I haz the power, 2017-03-13 14:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 14:15:34]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-03-13 14:38:34]

https://codereview.chromium.org/2744253002/diff/1/components/doodle/doodle_se...
File components/doodle/doodle_service.h (right):

https://codereview.chromium.org/2744253002/diff/1/components/doodle/doodle_se...
components/doodle/doodle_service.h:40: base::Clock* clock);
Passing the clock in as a raw pointer is a bit strange... How would this work in
production code? Could we pass it in as a std::unique_ptr?

[Marc Treib, 2017-03-13 14:51:37]

https://codereview.chromium.org/2744253002/diff/1/components/doodle/doodle_se...
File components/doodle/doodle_service.h (right):

https://codereview.chromium.org/2744253002/diff/1/components/doodle/doodle_se...
components/doodle/doodle_service.h:40: base::Clock* clock);
On 2017/03/13 14:38:33, Bernhard Bauer wrote:
> Passing the clock in as a raw pointer is a bit strange... How would this work
in
> production code? Could we pass it in as a std::unique_ptr?

Indeed, good catch. Done.

[Bernhard Bauer, 2017-03-13 14:52:38]

LGTM!

[Marc Treib, 2017-03-13 14:54:47]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 14:55:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 16:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:28:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2017-03-14 08:43:04]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-03-14 08:43:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
fhorschig@chromium.org
Link to the patchset: https://codereview.chromium.org/2744253002/#ps20001
(title: "pass clock as unique_ptr")

[commit-bot: I haz the power, 2017-03-14 08:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 09:23:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489480984825630,
"parent_rev": "e3af3eb4855470a1bded0e0bce5adbc0b93f3b8e", "commit_rev":
"76ee635828f448c9f1a873ec8a72406815cb4d12"}

[commit-bot: I haz the power, 2017-03-14 09:24:40]

Description was changed from

==========
[Doodle] Cache the DoodleConfig in prefs

BUG=690467
==========

to

==========
[Doodle] Cache the DoodleConfig in prefs

BUG=690467

Review-Url: https://codereview.chromium.org/2744253002
Cr-Commit-Position: refs/heads/master@{#456658}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ee635828f448c9f1a873ec8a72...
==========

[commit-bot: I haz the power, 2017-03-14 09:24:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76ee635828f448c9f1a873ec8a72...