Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2744243010: Use fast malloc for heap-allocated property tree builder context (Closed)

Created:
3 years, 9 months ago by pdr.
Modified:
3 years, 9 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use fast malloc for heap-allocated property tree builder context This patch switches to using fast malloc for the property tree builder context which should bring performance back to before https://codereview.chromium.org/2733143004 landed. Locally this improves blink_perf.paint complex-content-slow-scroll by 12.5% and blink_perf.paint prePaint by 12.4%. BUG=700996, 698653 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2744243010 Cr-Commit-Position: refs/heads/master@{#458131} Committed: https://chromium.googlesource.com/chromium/src/+/9d29c6383dcd86368b16b2993cb0eacb062d5a58

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h View 3 chunks +13 lines, -4 lines 2 comments Download

Messages

Total messages: 14 (9 generated)
pdr.
3 years, 9 months ago (2017-03-18 03:47:14 UTC) #5
Xianzhu
lgtm https://codereview.chromium.org/2744243010/diff/1/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h (right): https://codereview.chromium.org/2744243010/diff/1/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h#newcode68 third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h:68: const LayoutObject* containerForAbsolutePosition; Why change these?
3 years, 9 months ago (2017-03-20 16:20:24 UTC) #8
pdr.
https://codereview.chromium.org/2744243010/diff/1/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h (right): https://codereview.chromium.org/2744243010/diff/1/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h#newcode68 third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h:68: const LayoutObject* containerForAbsolutePosition; On 2017/03/20 at 16:20:24, Xianzhu wrote: ...
3 years, 9 months ago (2017-03-20 16:35:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744243010/1
3 years, 9 months ago (2017-03-20 16:35:59 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 18:34:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d29c6383dcd86368b16b2993cb0...

Powered by Google App Engine
This is Rietveld 408576698