Chromium Code Reviews Chromium Code Reviews
Issue 2744243006:
Ensure complete end-to-end browsertest coverage for absolute device orientation. (Closed)
| Index: content/test/data/device_sensors/device_orientation_absolute_test.html |
| diff --git a/content/test/data/device_sensors/device_orientation_absolute_test.html b/content/test/data/device_sensors/device_orientation_absolute_test.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..d9d1f0521b113a9984a913330aeba4e34a3b38c3 |
| --- /dev/null |
| +++ b/content/test/data/device_sensors/device_orientation_absolute_test.html |
| @@ -0,0 +1,35 @@ |
| +<html> |
| + <head> |
| + <title>DeviceOrientationAbsolute test</title> |
| + <script type="text/javascript"> |
| + function checkOrientationAbsoluteEvent(event) { |
| + // Return true iff the orientation is close enough to (3, 4, 5). |
|
Michael van Ouwerkerk
2017/03/16 10:42:32
nit: 3, 4, 5 or 4, 5, 6?
timvolodine
2017/03/16 15:50:02
indeed 4,5,6 thanks for catching this!
Done.
|
| + return Math.abs(event.alpha - 4) < 0.01 && |
| + Math.abs(event.beta - 5) < 0.01 && |
| + Math.abs(event.gamma - 6) < 0.01 && |
| + event.absolute == true; |
| + } |
| + |
| + function onOrientationAbsolute(event) { |
| + if (checkOrientationAbsoluteEvent(event)) { |
| + window.removeEventListener('deviceorientationabsolute', onOrientationAbsolute); |
| + pass(); |
| + } else { |
| + fail(); |
| + } |
| + } |
| + |
| + function pass() { |
| + document.getElementById('status').innerHTML = 'PASS'; |
| + document.location = '#pass'; |
| + } |
| + |
| + function fail() { |
| + document.location = '#fail'; |
| + } |
| + </script> |
| + </head> |
| + <body onLoad="window.addEventListener('deviceorientationabsolute', onOrientationAbsolute)"> |
| + <div id="status">FAIL</div> |
| + </body> |
| +</html> |
