Ensure complete end-to-end browsertest coverage for absolute device orientation.

Ensure complete end-to-end browsertest coverage for absolute device orientation.

Add end-to-end browser tests for the 'deviceorientationabsolute' event
to have full event coverage in device_sensors/.

BUG=702170
Review-Url: https://codereview.chromium.org/2744243006
Cr-Commit-Position: refs/heads/master@{#457449}
Committed: https://chromium.googlesource.com/chromium/src/+/8cb0391a72f48daf3680340a5dac9bc7302252a4

[timvolodine, 2017-03-15 19:07:55]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 19:08:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2017-03-15 19:12:09]

Description was changed from

==========
Update the end-to-end browsertest coverage for absolute device orientation.

Add end-to-end browser tests for the 'deviceorientationabsolute' event
to have full event coverage in device_sensors/.

BUG=
==========

to

==========
Extend the end-to-end browsertest coverage for absolute device orientation.

Add end-to-end browser tests for the 'deviceorientationabsolute' event
to have full event coverage in device_sensors/.

BUG=
==========

[timvolodine, 2017-03-15 19:12:31]

timvolodine@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:24:30]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2017-03-16 10:42:32]

lgtm with nit

https://codereview.chromium.org/2744243006/diff/1/content/test/data/device_se...
File content/test/data/device_sensors/device_orientation_absolute_test.html
(right):

https://codereview.chromium.org/2744243006/diff/1/content/test/data/device_se...
content/test/data/device_sensors/device_orientation_absolute_test.html:6: //
Return true iff the orientation is close enough to (3, 4, 5).
nit: 3, 4, 5 or 4, 5, 6?

[timvolodine, 2017-03-16 12:36:05]

Description was changed from

==========
Extend the end-to-end browsertest coverage for absolute device orientation.

Add end-to-end browser tests for the 'deviceorientationabsolute' event
to have full event coverage in device_sensors/.

BUG=
==========

to

==========
Extend the end-to-end browsertest coverage for absolute device orientation.

Add end-to-end browser tests for the 'deviceorientationabsolute' event
to have full event coverage in device_sensors/.

BUG=702170
==========

[timvolodine, 2017-03-16 12:42:18]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 12:42:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 13:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 13:34:06]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2017-03-16 15:48:38]

Description was changed from

==========
Extend the end-to-end browsertest coverage for absolute device orientation.

Add end-to-end browser tests for the 'deviceorientationabsolute' event
to have full event coverage in device_sensors/.

BUG=702170
==========

to

==========
Ensure complete end-to-end browsertest coverage for absolute device orientation.

Add end-to-end browser tests for the 'deviceorientationabsolute' event
to have full event coverage in device_sensors/.

BUG=702170
==========

[timvolodine, 2017-03-16 15:50:03]

Thanks Michael!

https://codereview.chromium.org/2744243006/diff/1/content/test/data/device_se...
File content/test/data/device_sensors/device_orientation_absolute_test.html
(right):

https://codereview.chromium.org/2744243006/diff/1/content/test/data/device_se...
content/test/data/device_sensors/device_orientation_absolute_test.html:6: //
Return true iff the orientation is close enough to (3, 4, 5).
On 2017/03/16 10:42:32, Michael van Ouwerkerk wrote:
> nit: 3, 4, 5 or 4, 5, 6?
indeed 4,5,6 thanks for catching this!

Done.

[timvolodine, 2017-03-16 15:50:33]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2017-03-16 15:50:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/2744243006/#ps20001
(title: "Michael's comment")

[commit-bot: I haz the power, 2017-03-16 15:51:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 15:58:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489679433486130,
"parent_rev": "1ab02803664abf6094e39d124ab83bfe7c418587", "commit_rev":
"8cb0391a72f48daf3680340a5dac9bc7302252a4"}

[commit-bot: I haz the power, 2017-03-16 15:59:28]

Description was changed from

==========
Ensure complete end-to-end browsertest coverage for absolute device orientation.

Add end-to-end browser tests for the 'deviceorientationabsolute' event
to have full event coverage in device_sensors/.

BUG=702170
==========

to

==========
Ensure complete end-to-end browsertest coverage for absolute device orientation.

Add end-to-end browser tests for the 'deviceorientationabsolute' event
to have full event coverage in device_sensors/.

BUG=702170

Review-Url: https://codereview.chromium.org/2744243006
Cr-Commit-Position: refs/heads/master@{#457449}
Committed:
https://chromium.googlesource.com/chromium/src/+/8cb0391a72f48daf3680340a5dac...
==========

[commit-bot: I haz the power, 2017-03-16 15:59:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8cb0391a72f48daf3680340a5dac...