Re-enable TextFloatsAroundFloatsBefore and check left offsets only

Re-enable TextFloatsAroundFloatsBefore and check left offsets only

http://crrev.com/2739683006 broke one of downstream bots
"WebKit Android (Nexus4)"
Here is the bot's output
  Value of: inline_text_box2->frameRect().location()
   Actual: "30,23"
  Expected: LayoutPoint(30, 22)
   Which is: "30,22"
  Value of: inline_text_box3->frameRect().location()
   Actual: "0,46"
  Expected: LayoutPoint(0, 44)
   Which is: "0,44"

I think it happened because of the difference in sizes between
different fallback fonts on different platforms. I don't have
permissions to run a downstream bot

$ git cl try -m master.chromium.webkit -b "WebKit Android (Nexus4)"
ERROR: Access denied: User user:glebl@chromium.org cannot
add builds to bucket master.chromium.webkit

But it's clear that the test failed while checking the height.

This patch re-enable TextFloatsAroundFloatsBefore and make it to check
what matters, i.e. left offsets.

BUG=700868
Review-Url: https://codereview.chromium.org/2744213004
Cr-Commit-Position: refs/heads/master@{#456467}
Committed: https://chromium.googlesource.com/chromium/src/+/fdda6d5acfde5d7083995597ddddeb08588728cd

[Gleb Lanbin, 2017-03-13 17:19:48]

Description was changed from

==========
Try

BUG=
==========

to

==========
Re-enable TextFloatsAroundFloatsBefore and check left offsets only

http://crrev.com/2739683006 broke one of downstream bots
"WebKit Android (Nexus4)"
Here is the bot's output
  Value of: inline_text_box2->frameRect().location() 
   Actual: "30,23"
  Expected: LayoutPoint(30, 22)
   Which is: "30,22"
  Value of: inline_text_box3->frameRect().location()
   Actual: "0,46"
  Expected: LayoutPoint(0, 44)
   Which is: "0,44"

I think it happened because of the difference in sizes between
different fallback fonts on different platforms. I don't have
permissions to run a downstream bot

$ git cl try -m master.chromium.webkit -b "WebKit Android (Nexus4)"
ERROR: Access denied: User user:glebl@chromium.org cannot
add builds to bucket master.chromium.webkit

But it's clear that the test failed while checking the height.

This patch re-enable TextFloatsAroundFloatsBefore and make it to check
what matters, i.e. left offsets.

BUG=700868
==========

[Gleb Lanbin, 2017-03-13 17:20:15]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2017-03-13 17:24:03]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 17:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gleb Lanbin, 2017-03-13 17:25:32]

Patchset #1 (id:1) has been deleted

[ikilpatrick, 2017-03-13 17:33:45]

lgtm

[ikilpatrick, 2017-03-13 17:33:45]

lgtm

lgtm

[commit-bot: I haz the power, 2017-03-13 18:31:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 18:31:45]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2017-03-13 19:24:22]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-13 19:24:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 20:31:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489433062751000,
"parent_rev": "f93b15725455ca57b95e54569a569dae99f3ffa3", "commit_rev":
"fdda6d5acfde5d7083995597ddddeb08588728cd"}

[commit-bot: I haz the power, 2017-03-13 20:37:20]

Description was changed from

==========
Re-enable TextFloatsAroundFloatsBefore and check left offsets only

http://crrev.com/2739683006 broke one of downstream bots
"WebKit Android (Nexus4)"
Here is the bot's output
  Value of: inline_text_box2->frameRect().location() 
   Actual: "30,23"
  Expected: LayoutPoint(30, 22)
   Which is: "30,22"
  Value of: inline_text_box3->frameRect().location()
   Actual: "0,46"
  Expected: LayoutPoint(0, 44)
   Which is: "0,44"

I think it happened because of the difference in sizes between
different fallback fonts on different platforms. I don't have
permissions to run a downstream bot

$ git cl try -m master.chromium.webkit -b "WebKit Android (Nexus4)"
ERROR: Access denied: User user:glebl@chromium.org cannot
add builds to bucket master.chromium.webkit

But it's clear that the test failed while checking the height.

This patch re-enable TextFloatsAroundFloatsBefore and make it to check
what matters, i.e. left offsets.

BUG=700868
==========

to

==========
Re-enable TextFloatsAroundFloatsBefore and check left offsets only

http://crrev.com/2739683006 broke one of downstream bots
"WebKit Android (Nexus4)"
Here is the bot's output
  Value of: inline_text_box2->frameRect().location()
   Actual: "30,23"
  Expected: LayoutPoint(30, 22)
   Which is: "30,22"
  Value of: inline_text_box3->frameRect().location()
   Actual: "0,46"
  Expected: LayoutPoint(0, 44)
   Which is: "0,44"

I think it happened because of the difference in sizes between
different fallback fonts on different platforms. I don't have
permissions to run a downstream bot

$ git cl try -m master.chromium.webkit -b "WebKit Android (Nexus4)"
ERROR: Access denied: User user:glebl@chromium.org cannot
add builds to bucket master.chromium.webkit

But it's clear that the test failed while checking the height.

This patch re-enable TextFloatsAroundFloatsBefore and make it to check
what matters, i.e. left offsets.

BUG=700868

Review-Url: https://codereview.chromium.org/2744213004
Cr-Commit-Position: refs/heads/master@{#456467}
Committed:
https://chromium.googlesource.com/chromium/src/+/fdda6d5acfde5d7083995597dddd...
==========

[commit-bot: I haz the power, 2017-03-13 20:37:21]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fdda6d5acfde5d7083995597dddd...