[debugger] fix switch block source positions.

[debugger] fix switch block source positions.

The switch statement itself is part of the switch block.
However, the source position of the statement is outside of
the block. This leads to confusion for the debugger, if the
switch block pushes a block context: the current context is
a block context, but the scope analysis based on the current
source position tells the debugger that we should be outside
the scope, so we should have the function context.

R=marja@chromium.org
BUG=v8:6085
Review-Url: https://codereview.chromium.org/2744213003
Cr-Commit-Position: refs/heads/master@{#43744}
Committed: https://chromium.googlesource.com/v8/v8/+/09de9969ccb9bc3bbd667788afad665b309d02f5

[Yang, 2017-03-13 12:23:25]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 12:23:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-03-13 12:24:46]

lgtm % nit

https://codereview.chromium.org/2744213003/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2744213003/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1668: DCHECK(!scope || switch_statement->position() >=
scope->start_position());
Nit: DCHECK_IMPLIES(scope != nullptr, ...)

[Yang, 2017-03-13 12:28:17]

On 2017/03/13 12:24:46, marja wrote:
> lgtm % nit
> 
> https://codereview.chromium.org/2744213003/diff/1/src/parsing/parser.cc
> File src/parsing/parser.cc (right):
> 
>
https://codereview.chromium.org/2744213003/diff/1/src/parsing/parser.cc#newco...
> src/parsing/parser.cc:1668: DCHECK(!scope || switch_statement->position() >=
> scope->start_position());
> Nit: DCHECK_IMPLIES(scope != nullptr, ...)

Thanks! Nit addressed.

[Yang, 2017-03-13 12:28:22]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-03-13 12:28:22]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2744213003/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2017-03-13 12:28:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 12:47:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489408102178160,
"parent_rev": "098f939d1448e92b715fed45870a16923dfcfef7", "commit_rev":
"09de9969ccb9bc3bbd667788afad665b309d02f5"}

[commit-bot: I haz the power, 2017-03-13 12:47:54]

Description was changed from

==========
[debugger] fix switch block source positions.

The switch statement itself is part of the switch block.
However, the source position of the statement is outside of
the block. This leads to confusion for the debugger, if the
switch block pushes a block context: the current context is
a block context, but the scope analysis based on the current
source position tells the debugger that we should be outside
the scope, so we should have the function context.

R=marja@chromium.org
BUG=v8:6085
==========

to

==========
[debugger] fix switch block source positions.

The switch statement itself is part of the switch block.
However, the source position of the statement is outside of
the block. This leads to confusion for the debugger, if the
switch block pushes a block context: the current context is
a block context, but the scope analysis based on the current
source position tells the debugger that we should be outside
the scope, so we should have the function context.

R=marja@chromium.org
BUG=v8:6085

Review-Url: https://codereview.chromium.org/2744213003
Cr-Commit-Position: refs/heads/master@{#43744}
Committed:
https://chromium.googlesource.com/v8/v8/+/09de9969ccb9bc3bbd667788afad665b309...
==========

[commit-bot: I haz the power, 2017-03-13 12:47:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/09de9969ccb9bc3bbd667788afad665b309...