Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2744173002: [csa] Remove context inputs from StrictEqual, SameValue and Typeof. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Remove context inputs from StrictEqual, SameValue and Typeof. These operations don't need the context, so no need to pass the context to them. Also avoids the loading of context in the interpreter bytecode handlers for StrictEqual and Typeof. BUG=v8:5268, v8:5269 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2744173002 Cr-Commit-Position: refs/heads/master@{#43733} Committed: https://chromium.googlesource.com/v8/v8/+/4da9b8afac4093481da20713be6a9a4ced6b95db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M src/builtins/builtins-conversion.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/builtins-number.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/builtins-promise.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/code-stub-assembler.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-13 05:14:08 UTC) #1
Benedikt Meurer
Hey Yang, Here's some cleanup. Please take a look. Thanks, Benedikt
3 years, 9 months ago (2017-03-13 05:14:29 UTC) #4
Yang
On 2017/03/13 05:14:29, Benedikt Meurer wrote: > Hey Yang, > > Here's some cleanup. > ...
3 years, 9 months ago (2017-03-13 05:58:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744173002/1
3 years, 9 months ago (2017-03-13 05:58:46 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 06:00:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4da9b8afac4093481da20713be6a9a4ced6...

Powered by Google App Engine
This is Rietveld 408576698