Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2744153002: Use parseFromString type arg to set mime type. (Closed)

Created:
3 years, 9 months ago by MartinRogalla
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use parseFromString type arg to set mime type. This patch ensures that the type argument for parseFromString(str, type) [1] is used to set the MIME type of the resulting document. It makes all DOMParser tests in [2] pass. [1] - https://w3c.github.io/DOM-Parsing/#dom-domparser-parsefromstring [2] - http://w3c-test.org/dom/nodes/Document-createElement-namespace.html BUG=700237 Review-Url: https://codereview.chromium.org/2744153002 Cr-Commit-Position: refs/heads/master@{#456325} Committed: https://chromium.googlesource.com/chromium/src/+/991d1fb3865a730afd1d1891ace471cb59432d8b

Patch Set 1 #

Patch Set 2 : Fixed parseFromString-xml test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createElement-namespace-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/domparsing/DOMParser-parseFromString-xml-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DOMParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
MartinRogalla
3 years, 9 months ago (2017-03-13 01:38:17 UTC) #1
tkent
please update the test result of external/wpt/domparsing/DOMParser-parseFromString-xml.html .
3 years, 9 months ago (2017-03-13 03:08:54 UTC) #6
MartinRogalla
On 2017/03/13 03:08:54, tkent wrote: > please update the test result of > external/wpt/domparsing/DOMParser-parseFromString-xml.html . ...
3 years, 9 months ago (2017-03-13 03:17:58 UTC) #7
tkent
lgtm
3 years, 9 months ago (2017-03-13 05:01:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744153002/20001
3 years, 9 months ago (2017-03-13 05:01:56 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 05:30:56 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/991d1fb3865a730afd1d1891ace4...

Powered by Google App Engine
This is Rietveld 408576698