Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2744143002: Remove unused methods in Git and related classes. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused methods in Git and related classes. BUG=677561 Review-Url: https://codereview.chromium.org/2744143002 Cr-Commit-Position: refs/heads/master@{#456480} Committed: https://chromium.googlesource.com/chromium/src/+/9a7c3aa0fab1e802536f66dea76b7248b2e16476

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_mock.py View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
qyearsley
3 years, 9 months ago (2017-03-13 16:23:52 UTC) #2
jeffcarp
lgtm
3 years, 9 months ago (2017-03-13 17:03:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744143002/1
3 years, 9 months ago (2017-03-13 17:27:21 UTC) #5
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-13 18:29:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744143002/20001
3 years, 9 months ago (2017-03-13 19:55:10 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 21:07:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a7c3aa0fab1e802536f66dea76b...

Powered by Google App Engine
This is Rietveld 408576698