Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2744123002: s390: Fix to use correct compare instruction (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

s390: Fix to use correct compare instruction BUG= LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=machenbach@chromium.org, jyan@ca.ibm.com Review-Url: https://codereview.chromium.org/2744123002 Cr-Commit-Position: refs/branch-heads/5.7@{#144} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/e200c9bef3fa0ca4d4418b88dd7560b8b4d9496e

Patch Set 1 #

Patch Set 2 : fixed other cmp instr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/s390/code-stubs-s390.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
JaideepBajwa
ptal, this fix cannot be applied to the truck (and 5.8) as the affected code ...
3 years, 9 months ago (2017-03-12 05:54:19 UTC) #1
john.yan
lgtm
3 years, 9 months ago (2017-03-12 17:32:31 UTC) #2
Michael Hablich
On 2017/03/12 17:32:31, john.yan wrote: > lgtm rubberstamp lgtm.
3 years, 9 months ago (2017-03-13 09:14:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744123002/20001
3 years, 9 months ago (2017-03-13 14:00:48 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 14:01:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e200c9bef3fa0ca4d4418b88dd7560b8b4d...

Powered by Google App Engine
This is Rietveld 408576698