Use BaseShellDialog for print dialog on Windows

ui/shell_dialogs/print_settings_dialog_win.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_SHELL_DIALOGS_PRINT_SETTINGS_DIALOG_WIN_H_
+#define UI_SHELL_DIALOGS_PRINT_SETTINGS_DIALOG_WIN_H_
+
+#include <ocidl.h>
+#include <commdlg.h>
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "ui/shell_dialogs/base_shell_dialog_win.h"
+#include "ui/shell_dialogs/shell_dialogs_export.h"
+
+namespace ui {
+
+// A thin wrapper around the native window print dialog that uses
+// BaseShellDialog to have the dialog run on a background thread.
+class SHELL_DIALOGS_EXPORT PrintSettingsDialogWin
+    : public base::RefCountedThreadSafe<PrintSettingsDialogWin>,
+      public BaseShellDialogImpl {
+ public:
+  class SHELL_DIALOGS_EXPORT Listener {

[sky, 2013/10/16 14:16:32]

We generally use Observer.

[scottmg, 2013/10/16 16:06:21]

Done.

+   public:
+    virtual void PrintSettingsConfirmed(PRINTDLGEX* dialog_options) = 0;
+    virtual void PrintSettingsCancelled(PRINTDLGEX* dialog_options) = 0;
+  };

[sky, 2013/10/16 14:16:32]

virtual protected destructor.

[scottmg, 2013/10/16 16:06:21]

Done. (PrintingContextWin implements PrintSettingsDialogWin::Observer not the
main class so it has to be public.)

+  typedef HRESULT(__stdcall* PrintDialogFunc)(PRINTDLGEX*);
+
+  PrintSettingsDialogWin(Listener* listener);

[sky, 2013/10/16 14:16:32]

explicit

[scottmg, 2013/10/16 16:06:21]

Done.

+
+  void GetPrintSettings(

[sky, 2013/10/16 14:16:32]

Add descriptions for functions.

[scottmg, 2013/10/16 16:06:21]

Done.

+      PrintDialogFunc print_dialog_func,
+      HWND owning_window,
+      PRINTDLGEX* dialog_options);
+
+ private:
+  // Listener that's notified when the dialog is confirmed or cancelled.
+  Listener* listener_;

[sky, 2013/10/16 14:16:32]

members last.

[scottmg, 2013/10/16 16:06:21]

Done.

+
+  // A struct for holding all the state necessary for displaying the print
+  // settings dialog.
+  struct ExecutePrintSettingsParams {
+    ExecutePrintSettingsParams(RunState run_state,
+                               HWND owner,
+                               PrintDialogFunc print_dialog_func,
+                               PRINTDLGEX* dialog_options)
+        : run_state(run_state),
+          owner(owner),
+          print_dialog_func(print_dialog_func),
+          dialog_options(dialog_options),
+          ui_proxy(base::MessageLoopForUI::current()->message_loop_proxy()) {}
+
+    RunState run_state;
+    HWND owner;
+    PrintDialogFunc print_dialog_func;
+    PRINTDLGEX* dialog_options;
+    scoped_refptr<base::MessageLoopProxy> ui_proxy;
+  };
+
+  void ExecutePrintSettings(const ExecutePrintSettingsParams& params);
+
+  void PrintSettingsCompleted(HRESULT hresult,
+                              const ExecutePrintSettingsParams& params);
+};

[sky, 2013/10/16 14:16:32]

DISALLOW...

[scottmg, 2013/10/16 16:06:21]

Done.

+
+}  // namespace ui
+
+#endif  // UI_SHELL_DIALOGS_PRINT_SETTINGS_DIALOG_WIN_H_