Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2744063002: Revert of cc::ResourcePool - Re-use larger resources for smaller requests (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
danakj, enne (OOO), ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc::ResourcePool - Re-use larger resources for smaller requests (patchset #4 id:140001 of https://codereview.chromium.org/2726263003/ ) Reason for revert: This seems to cause flakiness of several border-radius tests, e.g. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=compositing%2Foverflow%2Fgrandchild-composited-with-border-radius-ancestor.html Speculatively revert, to see if it's this CL. Original issue's description: > cc::ResourcePool - Re-use larger resources for smaller requests > > Allows cc::ResourcePool to re-use larger resources to fulfill a smaller > request. This avoids expensive allocations, and is especially useful in > cases where layer sizes are changing due to animation. > > Also extends the timeout for resource expiration from 1s to 5s, which > will also cut down on resource allocations. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2726263003 > Cr-Commit-Position: refs/heads/master@{#456202} > Committed: https://chromium.googlesource.com/chromium/src/+/830cb220146684c38b9aa4da3f39e96c37a59f33 TBR=enne@chromium.org,danakj@chromium.org,ericrk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2744063002 Cr-Commit-Position: refs/heads/master@{#456257} Committed: https://chromium.googlesource.com/chromium/src/+/085571c2c97e2915a1e40262f6d1aaf20e9defb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -84 lines) Patch
M cc/resources/resource_pool.cc View 2 chunks +2 lines, -29 lines 0 comments Download
M cc/resources/resource_pool_unittest.cc View 3 chunks +31 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Xianzhu
Created Revert of cc::ResourcePool - Re-use larger resources for smaller requests
3 years, 9 months ago (2017-03-11 02:16:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744063002/1
3 years, 9 months ago (2017-03-11 02:16:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/085571c2c97e2915a1e40262f6d1aaf20e9defb7
3 years, 9 months ago (2017-03-11 02:18:13 UTC) #6
Xianzhu
3 years, 9 months ago (2017-03-11 04:34:20 UTC) #7
Message was sent while issue was closed.
The tests are no longer flaky after this revert:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType...

Powered by Google App Engine
This is Rietveld 408576698