Issue 2743903002: Revert "Do not rely on code patching on DBC for lazy deoptimization."

Issue 2743903002: Revert "Do not rely on code patching on DBC for lazy deoptimization." (Closed)

Created:
3 years, 9 months ago by erikcorry

Modified:
3 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Do not rely on code patching on DBC for lazy deoptimization." This reverts commit 6efb75b22f60a1155f17e3f76e64f962f515710e. This is a speculative revert to try to make the tests green. R=ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7d624bccd0e026073fb2be379141a6441d0e1916

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -41 lines)			Patch
M	runtime/vm/code_generator.cc	View	5 chunks	+27 lines, -1 line	0 comments	Download
M	runtime/vm/code_patcher.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/code_patcher_arm.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/code_patcher_arm64.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/code_patcher_dbc.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/code_patcher_ia32.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/code_patcher_mips.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/code_patcher_x64.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/exceptions.cc	View	6 chunks	+8 lines, -9 lines	0 comments	Download
M	runtime/vm/instructions_dbc.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/instructions_dbc.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/simulator_dbc.cc	View	4 chunks	+3 lines, -23 lines	0 comments	Download
M	runtime/vm/stub_code_dbc.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

erikcorry

Committed patchset #1 (id:1) manually as 7d624bccd0e026073fb2be379141a6441d0e1916 (presubmit successful).

3 years, 9 months ago (2017-03-10 09:02:08 UTC) #3

Message was sent while issue was closed.

lgtm