Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: runtime/vm/stub_code_dbc.cc

Issue 2743903002: Revert "Do not rely on code patching on DBC for lazy deoptimization." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/simulator_dbc.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_DBC) 6 #if defined(TARGET_ARCH_DBC)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 43
44 // Not executed, but used as a sentinel in Simulator::JumpToFrame. 44 // Not executed, but used as a sentinel in Simulator::JumpToFrame.
45 void StubCode::GenerateRunExceptionHandlerStub(Assembler* assembler) { 45 void StubCode::GenerateRunExceptionHandlerStub(Assembler* assembler) {
46 __ Trap(); 46 __ Trap();
47 } 47 }
48 48
49 49
50 void StubCode::GenerateDeoptForRewindStub(Assembler* assembler) { 50 void StubCode::GenerateDeoptForRewindStub(Assembler* assembler) {
51 __ DeoptRewind(); 51 __ DeoptRewind();
52 __ Trap();
53 } 52 }
54 53
55 54
56 // TODO(vegorov) Don't generate this stub. 55 // TODO(vegorov) Don't generate this stub.
57 void StubCode::GenerateFixCallersTargetStub(Assembler* assembler) { 56 void StubCode::GenerateFixCallersTargetStub(Assembler* assembler) {
58 __ Trap(); 57 __ Trap();
59 } 58 }
60 59
61 60
62 // TODO(vegorov) Don't generate these stubs. 61 // TODO(vegorov) Don't generate these stubs.
63 void StubCode::GenerateAllocationStubForClass(Assembler* assembler, 62 void StubCode::GenerateAllocationStubForClass(Assembler* assembler,
64 const Class& cls) { 63 const Class& cls) {
65 __ Trap(); 64 __ Trap();
66 } 65 }
67 66
68 67
69 // TODO(vegorov) Don't generate this stub. 68 // TODO(vegorov) Don't generate this stub.
70 void StubCode::GenerateMegamorphicMissStub(Assembler* assembler) { 69 void StubCode::GenerateMegamorphicMissStub(Assembler* assembler) {
71 __ Trap(); 70 __ Trap();
72 } 71 }
73 72
74 73
75 // These deoptimization stubs are only used to populate stack frames 74 // These deoptimization stubs are only used to populate stack frames
76 // with something meaningful to make sure GC can scan the stack during 75 // with something meaningful to make sure GC can scan the stack during
77 // the last phase of deoptimization which materializes objects. 76 // the last phase of deoptimization which materializes objects.
78 void StubCode::GenerateDeoptimizeLazyFromReturnStub(Assembler* assembler) { 77 void StubCode::GenerateDeoptimizeLazyFromReturnStub(Assembler* assembler) {
79 __ Deopt(0 /* unused */, 0 /* lazy */); 78 __ Trap();
80 __ Trap(); // Not reached: pc is updated as part of deoptimization.
81 } 79 }
82 80
83 81
84 void StubCode::GenerateDeoptimizeLazyFromThrowStub(Assembler* assembler) { 82 void StubCode::GenerateDeoptimizeLazyFromThrowStub(Assembler* assembler) {
85 __ Deopt(0 /* unused */, 0 /* lazy */); 83 __ Trap();
86 __ Trap(); // Not reached: pc is updated as part of deoptimization.
87 } 84 }
88 85
89 86
90 void StubCode::GenerateDeoptimizeStub(Assembler* assembler) { 87 void StubCode::GenerateDeoptimizeStub(Assembler* assembler) {
91 __ Trap(); 88 __ Trap();
92 } 89 }
93 90
94 91
95 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) { 92 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) {
96 __ Trap(); 93 __ Trap();
97 } 94 }
98 95
99 96
100 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) { 97 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) {
101 __ Trap(); 98 __ Trap();
102 } 99 }
103 100
104 101
105 // Print the stop message. 102 // Print the stop message.
106 DEFINE_LEAF_RUNTIME_ENTRY(void, PrintStopMessage, 1, const char* message) { 103 DEFINE_LEAF_RUNTIME_ENTRY(void, PrintStopMessage, 1, const char* message) {
107 OS::Print("Stop message: %s\n", message); 104 OS::Print("Stop message: %s\n", message);
108 } 105 }
109 END_LEAF_RUNTIME_ENTRY 106 END_LEAF_RUNTIME_ENTRY
110 107
111 } // namespace dart 108 } // namespace dart
112 109
113 #endif // defined TARGET_ARCH_DBC 110 #endif // defined TARGET_ARCH_DBC
OLDNEW
« no previous file with comments | « runtime/vm/simulator_dbc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698