Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2743833002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, zea+watch_chromium.org, mvanouwerkerk+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, blink-reviews, jam, timvolodine, abarth-chromium, mlamouri+watch-blink_chromium.org, darin-cc_chromium.org, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (geolocation, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=mvanouwerkerk@chromium.org Review-Url: https://codereview.chromium.org/2743833002 Cr-Commit-Position: refs/heads/master@{#456398} Committed: https://chromium.googlesource.com/chromium/src/+/7756031c15ae03bcfaf83bf25898bb85176c0ca2

Patch Set 1 : update #

Total comments: 8

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M components/gcm_driver/android/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M device/geolocation/public/interfaces/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-10 00:34:52 UTC) #4
Michael van Ouwerkerk
https://codereview.chromium.org/2743833002/diff/20001/components/gcm_driver/android/OWNERS File components/gcm_driver/android/OWNERS (right): https://codereview.chromium.org/2743833002/diff/20001/components/gcm_driver/android/OWNERS#newcode4 components/gcm_driver/android/OWNERS:4: # COMPONENT: Infra>Client>Android Please get a review from peter@chromium.org ...
3 years, 9 months ago (2017-03-10 15:40:58 UTC) #6
Michael van Ouwerkerk
https://codereview.chromium.org/2743833002/diff/20001/third_party/WebKit/Source/modules/vibration/OWNERS File third_party/WebKit/Source/modules/vibration/OWNERS (right): https://codereview.chromium.org/2743833002/diff/20001/third_party/WebKit/Source/modules/vibration/OWNERS#newcode3 third_party/WebKit/Source/modules/vibration/OWNERS:3: # TEAM: platform-capabilities@chromium.org On 2017/03/10 15:40:57, Michael van Ouwerkerk ...
3 years, 9 months ago (2017-03-10 15:42:17 UTC) #7
Peter Beverloo
https://codereview.chromium.org/2743833002/diff/20001/components/gcm_driver/android/OWNERS File components/gcm_driver/android/OWNERS (right): https://codereview.chromium.org/2743833002/diff/20001/components/gcm_driver/android/OWNERS#newcode4 components/gcm_driver/android/OWNERS:4: # COMPONENT: Infra>Client>Android Please use Services>CloudMessaging. https://codereview.chromium.org/2743833002/diff/20001/third_party/WebKit/Source/modules/vibration/OWNERS File third_party/WebKit/Source/modules/vibration/OWNERS ...
3 years, 9 months ago (2017-03-10 15:46:55 UTC) #8
ymzhang1
https://codereview.chromium.org/2743833002/diff/20001/components/gcm_driver/android/OWNERS File components/gcm_driver/android/OWNERS (right): https://codereview.chromium.org/2743833002/diff/20001/components/gcm_driver/android/OWNERS#newcode4 components/gcm_driver/android/OWNERS:4: # COMPONENT: Infra>Client>Android On 2017/03/10 15:46:55, Peter Beverloo wrote: ...
3 years, 9 months ago (2017-03-10 18:20:15 UTC) #9
Michael van Ouwerkerk
lgtm
3 years, 9 months ago (2017-03-13 09:58:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743833002/40001
3 years, 9 months ago (2017-03-13 15:30:45 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 16:36:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7756031c15ae03bcfaf83bf25898...

Powered by Google App Engine
This is Rietveld 408576698