cc: Optimize GenerateDiscardableImagesMetadata for display items.

cc: Optimize GenerateDiscardableImagesMetadata for display items.

After an observation that we don't actually need an rtree or a scale
to gather discardable images (we process every item at scale 1.f), we
decided that it's best to replicate a few lines of the raster code at
the benefit of faster implementation and less peak memory.

This patch does this. This path is already tested by cc_unittests.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2743793002
Cr-Commit-Position: refs/heads/master@{#455917}
Committed: https://chromium.googlesource.com/chromium/src/+/9b2ce42c3e9b02e8037b494a32a47cabd5f6e2a9

[vmpstr, 2017-03-09 22:00:21]

Description was changed from

==========
cc: Optimize GenerateDiscardableImagesMetadata for display items.

After an observation that we don't actually need an rtree or a scale
to gather discardable images (we process every item at scale 1.f), we
decided that it's best to replicate a few lines of the raster code at
the benefit of faster implementation and less peak memory.

This patch does this. This path is already tested by cc_unittests.

R=danakj@chromium.org
==========

to

==========
cc: Optimize GenerateDiscardableImagesMetadata for display items.

After an observation that we don't actually need an rtree or a scale
to gather discardable images (we process every item at scale 1.f), we
decided that it's best to replicate a few lines of the raster code at
the benefit of faster implementation and less peak memory.

This patch does this. This path is already tested by cc_unittests.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2017-03-09 22:00:41]

Please take a look.

[danakj, 2017-03-09 23:14:13]

LGTM

[vmpstr, 2017-03-09 23:18:38]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-03-09 23:19:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 00:13:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489101518702270, "parent_rev":
"e697ecc17f3bc625679703723c44333854d1a06c", "commit_rev":
"9b2ce42c3e9b02e8037b494a32a47cabd5f6e2a9"}

[commit-bot: I haz the power, 2017-03-10 00:14:01]

Description was changed from

==========
cc: Optimize GenerateDiscardableImagesMetadata for display items.

After an observation that we don't actually need an rtree or a scale
to gather discardable images (we process every item at scale 1.f), we
decided that it's best to replicate a few lines of the raster code at
the benefit of faster implementation and less peak memory.

This patch does this. This path is already tested by cc_unittests.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Optimize GenerateDiscardableImagesMetadata for display items.

After an observation that we don't actually need an rtree or a scale
to gather discardable images (we process every item at scale 1.f), we
decided that it's best to replicate a few lines of the raster code at
the benefit of faster implementation and less peak memory.

This patch does this. This path is already tested by cc_unittests.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2743793002
Cr-Commit-Position: refs/heads/master@{#455917}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b2ce42c3e9b02e8037b494a32a4...
==========

[commit-bot: I haz the power, 2017-03-10 00:14:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b2ce42c3e9b02e8037b494a32a4...